Subject: Re: [PATCH] net: macb: remove change_mtu callback

From: Simon Horman <[email-masked]>
Date: Sat, 9 Mar 2024 14:54:41 +0000

On Fri, Mar 08, 2024 at 04:53:30PM +0100, [email-masked] wrote:
> From: Thomas Perrot <[email-masked]>
> 
> Because it doesn't allow MTU changes when the interface is up, although
> it is not necessary.
> 
> This callback has been added to add in a first implementation of the Jumbo
> support [1],since it has been reworked and moved to the probe [2].
> 
> [1] commit a5898ea09aad ("net: macb: Add change_mtu callback with
>     jumbo support")
> [2] commit 44770e1180de ("ethernet: use core min/max MTU checking")
> 
> Signed-off-by: Thomas Perrot <[email-masked]>

Hi Thomas,

Perhaps it is worth mentioning that after this patch the core will set the
MTU, regardless of if the interface is up or not.