From: Stephen Hemminger <stephen@networkplumber•org>
To: Shradha Gupta <shradhagupta@linux•microsoft.com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Haiyang Zhang <haiyangz@microsoft•com>,
Shradha Gupta <shradhagupta@microsoft•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Ajay Sharma <sharmaajay@microsoft•com>,
Leon Romanovsky <leon@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
KY Srinivasan <kys@microsoft•com>, Wei Liu <wei.liu@kernel•org>,
Dexuan Cui <decui@microsoft•com>, Long Li <longli@microsoft•com>,
Michael Kelley <mikelley@microsoft•com>
Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device
Date: Mon, 11 Mar 2024 08:49:52 -0700 [thread overview]
Message-ID: <20240311084952.643dba6e@hermes.local> (raw)
In-Reply-To: <20240311041950.GA19647@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Sun, 10 Mar 2024 21:19:50 -0700
Shradha Gupta <shradhagupta@linux•microsoft.com> wrote:
> On Fri, Mar 08, 2024 at 11:22:44AM -0800, Jakub Kicinski wrote:
> > On Fri, 8 Mar 2024 18:51:58 +0000 Haiyang Zhang wrote:
> > > > Dynamic is a bit of an exaggeration, right? On a well-configured system
> > > > each CPU should use a single queue assigned thru XPS. And for manual
> > > > debug bpftrace should serve the purpose quite well.
> > >
> > > Some programs, like irqbalancer can dynamically change the CPU affinity,
> > > so we want to add the per-CPU counters for better understanding of the CPU
> > > usage.
> >
> > Do you have experimental data showing this making a difference
> > in production?
> Sure, will try to get that data for this discussion
> >
> > Seems unlikely, but if it does work we should enable it for all
> > devices, no driver by driver.
> You mean, if the usecase seems valid we should try to extend the framework
> mentioned by Rahul (https://lore.kernel.org/lkml/20240307072923.6cc8a2ba@kernel.org/)
> to include these stats as well?
> Will explore this a bit more and update. Thanks.
>
Remember, statistics aren't free, and even per-cpu stats end up taking cache space.
next prev parent reply other threads:[~2024-03-11 15:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 14:52 [PATCH] net :mana : Add per-cpu stats for MANA device Shradha Gupta
2024-03-07 15:29 ` Jakub Kicinski
2024-03-07 15:49 ` Haiyang Zhang
2024-03-07 17:01 ` Jakub Kicinski
2024-03-08 5:30 ` Shradha Gupta
2024-03-08 18:51 ` Haiyang Zhang
2024-03-08 19:22 ` Jakub Kicinski
2024-03-08 19:43 ` Haiyang Zhang
2024-03-08 19:52 ` Rahul Rameshbabu
2024-03-08 20:27 ` Jakub Kicinski
2024-03-08 20:33 ` Sebastian Andrzej Siewior
2024-03-11 4:19 ` Shradha Gupta
2024-03-11 15:49 ` Stephen Hemminger [this message]
2024-03-11 15:51 ` Jakub Kicinski
2024-03-11 16:41 ` Stephen Hemminger
2024-03-14 2:57 ` Shradha Gupta
2024-03-14 3:05 ` Stephen Hemminger
2024-03-14 18:27 ` Jakub Kicinski
2024-03-14 18:54 ` Haiyang Zhang
2024-03-14 19:05 ` Jakub Kicinski
2024-03-14 20:01 ` [EXTERNAL] " Alireza Dabagh
2024-04-03 5:43 ` Shradha Gupta
2024-03-07 16:17 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311084952.643dba6e@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=mikelley@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sharmaajay@microsoft$(echo .)com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=shradhagupta@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox