Subject: Re: [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols

From: Jakub Kicinski <[email-masked]>
Date: Mon, 11 Mar 2024 11:38:11 -0700

On Sat, 9 Mar 2024 14:35:30 -0800 David Wei wrote:
> On 2024-03-09 10:34, Jakub Kicinski wrote:
> > There are things in linux/genetlink.h which are only used
> > under net/netlink/. Move them to a new local header.
> > A new header with just 2 externs isn't great, but alternative
> > would be to include af_netlink.h in genetlink.c which feels
> > even worse.  
> 
> Why is including af_netlink.h worse?

It exposes the internals of the lower layer of the protocol stack.
genetlink.c doesn't really need to know those details.