Subject: Re: [PATCH net-next v1] netdevsim: replace pr_err with {dev,netdev,}_err wherever possible

From: Jakub Kicinski <[email-masked]>
Date: Mon, 11 Mar 2024 13:07:06 -0700

On Sat,  9 Mar 2024 17:52:15 -0800 David Wei wrote:
> -		pr_err("Failed to get snapshot id\n");
> +		dev_err(&nsim_dev->nsim_bus_dev->dev, "Failed to get snapshot id\n");

We seem to use dev_err(&nsim_dev->nsim_bus_dev->dev, ...
in quite a few places after this patch, how about we add a wrapper

#define nsim_err(ns_dev, args...) \
	dev_err(&(ns_dev)->nsim_bus_dev->dev(dev), ##args)
?
-- 
pw-bot: cr