Subject: Re: [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex

From: Simon Horman <[email-masked]>
Date: Wed, 20 Mar 2024 11:19:26 +0000

On Tue, Mar 19, 2024 at 03:16:55PM +0100, Erwan Velu wrote:
> If the MFS is set below the default (0x2600), a warning message is
> reported like the following :
> 
> 	MFS for port 1 has been set below the default: 600
> 
> This message is a bit confusing as the number shown here (600) is in
> fact an hexa number: 0x600 = 1536
> 
> Without any explicit "0x" prefix, this message is read like the MFS is
> set to 600 bytes.
> 
> MFS, as per MTUs, are usually expressed in decimal base.
> 
> This commit reports both current and default MFS values in decimal
> so it's less confusing for end-users.
> 
> A typical warning message looks like the following :
> 
> 	MFS for port 1 (1536) has been set below the default (9728)
> 

Hi Erwan,

If this is for (iwl-)net, then it should probably have a Fixes tag.
I expect it is sufficient to respond to this email with an appropriate tag.

> Signed-off-by: Erwan Velu <[email-masked]>

That not withstanding, this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>

...