From: Simon Horman <horms@kernel•org>
To: Claus Hansen Ries <chr@terma•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"kuba@kernel•org" <kuba@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"michal.simek@amd•com" <michal.simek@amd•com>,
"wei.fang@nxp•com" <wei.fang@nxp•com>,
"yangyingliang@huawei•com" <yangyingliang@huawei•com>,
"robh@kernel•org" <robh@kernel•org>,
"harini.katakam@amd•com" <harini.katakam@amd•com>,
"dan.carpenter@linaro•org" <dan.carpenter@linaro•org>,
"u.kleine-koenig@pengutronix•de" <u.kleine-koenig@pengutronix•de>,
"wanghai38@huawei•com" <wanghai38@huawei•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function
Date: Wed, 20 Mar 2024 15:22:46 +0000 [thread overview]
Message-ID: <20240320152246.GU185808@kernel.org> (raw)
In-Reply-To: <f512ff25a2cd484791757c18facb526c@terma.com>
On Wed, Mar 20, 2024 at 02:19:15PM +0000, Claus Hansen Ries wrote:
> From: Claus Hansen Ries <chr@terma•com>
>
> Hope I am resubmitting this correctly, I've fixed the issues in
> the original submission.
For future reference, the text above probably belongs
below the scissors ("---"). But I don't think there
is a need to resubmit just because of that.
>
> platform_get_resource was replaced with devm_platform_ioremap_resource_byname
> and is called using 0 as name. This eventually ends up in platform_get_resource_byname
> in the call stack, where it causes a null pointer in strcmp.
>
> if (type == resource_type(r) && !strcmp(r->name, name))
>
> It should have been replaced with devm_platform_ioremap_resource.
>
> Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()")
> Signed-off-by: Claus Hansen Ries <chr@terma•com>
> Cc: stable@vger•kernel.org
> ---
> v2:
> - fix accidently converting tabs to spaces and wording in commit message
> v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2
Thanks,
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-03-20 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 14:19 [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function Claus Hansen Ries
2024-03-20 15:22 ` Simon Horman [this message]
2024-03-20 16:06 ` Jiri Pirko
2024-03-21 12:51 ` Paolo Abeni
2024-03-21 13:08 ` [PATCH net v3] " Claus Hansen Ries
2024-03-26 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320152246.GU185808@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=chr@terma$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=harini.katakam@amd$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michal.simek@amd$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=wanghai38@huawei$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
--cc=yangyingliang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox