From: Greg KH <gregkh@linuxfoundation•org>
To: Allen Pais <apais@linux•microsoft.com>
Cc: linux-kernel@vger•kernel.org, tj@kernel•org,
keescook@chromium•org, vkoul@kernel•org, marcan@marcan•st,
sven@svenpeter•dev, florian.fainelli@broadcom•com,
rjui@broadcom•com, sbranden@broadcom•com, paul@crapouillou•net,
Eugeniy.Paltsev@synopsys•com, manivannan.sadhasivam@linaro•org,
vireshk@kernel•org, Frank.Li@nxp•com, leoyang.li@nxp•com,
zw@zh-kernel•org, wangzhou1@hisilicon•com, haijie1@huawei•com,
shawnguo@kernel•org, s.hauer@pengutronix•de,
sean.wang@mediatek•com, matthias.bgg@gmail•com,
angelogioacchino.delregno@collabora•com, afaerber@suse•de,
logang@deltatee•com, daniel@zonque•org, haojian.zhuang@gmail•com,
robert.jarzmik@free•fr, andersson@kernel•org,
konrad.dybcio@linaro•org, orsonzhai@gmail•com,
baolin.wang@linux•alibaba.com, zhang.lyra@gmail•com,
patrice.chotard@foss•st.com, linus.walleij@linaro•org,
wens@csie•org, jernej.skrabec@gmail•com,
peter.ujfalusi@gmail•com, kys@microsoft•com,
haiyangz@microsoft•com, wei.liu@kernel•org, decui@microsoft•com,
jassisinghbrar@gmail•com, mchehab@kernel•org,
maintainers@bluecherrydvr•com, aubin.constans@microchip•com,
ulf.hansson@linaro•org, manuel.lauss@gmail•com,
mirq-linux@rere•qmqm.pl, jh80.chung@samsung•com, oakad@yahoo•com,
hayashi.kunihiko@socionext•com, mhiramat@kernel•org,
brucechang@via•com.tw, HaraldWelte@viatech•com, pierre@ossman•eu,
duncan.sands@free•fr, stern@rowland•harvard.edu,
oneukum@suse•com, openipmi-developer@lists•sourceforge.net,
dmaengine@vger•kernel.org, asahi@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org, linux-mips@vger•kernel.org,
imx@lists•linux.dev, linuxppc-dev@lists•ozlabs.org,
linux-mediatek@lists•infradead.org,
linux-actions@lists•infradead.org, linux-arm-msm@vger•kernel.org,
linux-riscv@lists•infradead.org, linux-sunxi@lists•linux.dev,
linux-tegra@vger•kernel.org, linux-hyperv@vger•kernel.org,
linux-rdma@vger•kernel.org, linux-media@vger•kernel.org,
linux-mmc@vger•kernel.org, linux-omap@vger•kernel.org,
linux-renesas-soc@vger•kernel.org, linux-s390@vger•kernel.org,
netdev@vger•kernel.org, linux-usb@vger•kernel.org
Subject: Re: [PATCH 4/9] USB: Convert from tasklet to BH workqueue
Date: Wed, 27 Mar 2024 17:55:31 +0100 [thread overview]
Message-ID: <2024032753-probable-blatancy-80bf@gregkh> (raw)
In-Reply-To: <20240327160314.9982-5-apais@linux.microsoft.com>
On Wed, Mar 27, 2024 at 04:03:09PM +0000, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
>
> This patch converts drivers/infiniband/* from tasklet to BH workqueue.
No it does not, I think your changelog is wrong :(
>
> Based on the work done by Tejun Heo <tj@kernel•org>
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
>
> Signed-off-by: Allen Pais <allen.lkml@gmail•com>
> ---
> drivers/usb/atm/usbatm.c | 55 +++++++++++++++--------------
> drivers/usb/atm/usbatm.h | 3 +-
> drivers/usb/core/hcd.c | 22 ++++++------
> drivers/usb/gadget/udc/fsl_qe_udc.c | 21 +++++------
> drivers/usb/gadget/udc/fsl_qe_udc.h | 4 +--
> drivers/usb/host/ehci-sched.c | 2 +-
> drivers/usb/host/fhci-hcd.c | 3 +-
> drivers/usb/host/fhci-sched.c | 10 +++---
> drivers/usb/host/fhci.h | 5 +--
> drivers/usb/host/xhci-dbgcap.h | 3 +-
> drivers/usb/host/xhci-dbgtty.c | 15 ++++----
> include/linux/usb/cdc_ncm.h | 2 +-
> include/linux/usb/usbnet.h | 2 +-
> 13 files changed, 76 insertions(+), 71 deletions(-)
>
> diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
> index 2da6615fbb6f..74849f24e52e 100644
> --- a/drivers/usb/atm/usbatm.c
> +++ b/drivers/usb/atm/usbatm.c
> @@ -17,7 +17,7 @@
> * - Removed the limit on the number of devices
> * - Module now autoloads on device plugin
> * - Merged relevant parts of sarlib
> - * - Replaced the kernel thread with a tasklet
> + * - Replaced the kernel thread with a work
a "work"?
> * - New packet transmission code
> * - Changed proc file contents
> * - Fixed all known SMP races
> @@ -68,6 +68,7 @@
> #include <linux/wait.h>
> #include <linux/kthread.h>
> #include <linux/ratelimit.h>
> +#include <linux/workqueue.h>
>
> #ifdef VERBOSE_DEBUG
> static int usbatm_print_packet(struct usbatm_data *instance, const unsigned char *data, int len);
> @@ -249,7 +250,7 @@ static void usbatm_complete(struct urb *urb)
> /* vdbg("%s: urb 0x%p, status %d, actual_length %d",
> __func__, urb, status, urb->actual_length); */
>
> - /* Can be invoked from task context, protect against interrupts */
> + /* Can be invoked from work context, protect against interrupts */
"workqueue"? This too seems wrong.
Same for other comment changes in this patch.
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-27 16:55 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:03 [PATCH 0/9] Convert Tasklets to BH Workqueues Allen Pais
2024-03-27 16:03 ` [PATCH 1/9] hyperv: Convert from tasklet to BH workqueue Allen Pais
2024-04-03 16:43 ` Allen
2024-03-27 16:03 ` [PATCH 2/9] dma: " Allen Pais
2024-03-28 5:55 ` Vinod Koul
2024-03-28 10:08 ` Arnd Bergmann
2024-03-28 18:31 ` Vinod Koul
2024-03-28 19:39 ` Allen
2024-03-28 19:49 ` Arnd Bergmann
2024-03-28 20:01 ` Allen
2024-03-29 16:38 ` Vinod Koul
2024-03-29 16:39 ` Vinod Koul
2024-03-28 17:49 ` Allen
2024-04-02 12:25 ` Linus Walleij
2024-04-02 13:11 ` Vinod Koul
2024-03-27 16:03 ` [PATCH 3/9] IB: " Allen Pais
2024-04-07 18:56 ` Zhu Yanjun
2024-03-27 16:03 ` [PATCH 4/9] USB: " Allen Pais
2024-03-27 16:20 ` Duncan Sands
2024-03-27 16:55 ` Greg KH [this message]
2024-03-27 16:58 ` Allen
2024-03-27 17:55 ` Alan Stern
2024-03-28 17:54 ` Allen
2024-03-27 16:03 ` [PATCH 5/9] mailbox: " Allen Pais
2024-03-27 16:03 ` [PATCH 6/9] ipmi: " Allen Pais
2024-03-27 17:58 ` Corey Minyard
2024-03-28 17:52 ` Allen
2024-03-28 19:23 ` Corey Minyard
2024-03-28 19:41 ` Allen
2024-03-28 19:52 ` Corey Minyard
2024-03-28 19:58 ` Allen
2024-03-27 16:03 ` [PATCH 7/9] s390: " Allen Pais
2024-04-02 12:48 ` Alexandra Winter
2024-04-03 13:33 ` Allen
2024-04-08 9:33 ` Heiko Carstens
2024-04-08 10:03 ` Harald Freudenberger
2024-03-27 16:03 ` [PATCH 8/9] drivers/media/*: " Allen Pais
2024-04-24 9:12 ` Hans Verkuil
2024-04-24 16:48 ` Allen Pais
2024-03-27 16:03 ` [PATCH 9/9] mmc: " Allen Pais
2024-03-27 19:35 ` Jernej Škrabec
2024-03-28 10:16 ` Christian Loehle
2024-03-28 17:47 ` Allen
2024-03-28 12:53 ` Ulf Hansson
2024-03-28 13:37 ` Linus Walleij
2024-03-28 16:21 ` Tejun Heo
2024-04-02 10:15 ` Ulf Hansson
2024-04-05 9:28 ` Michał Mirosław
2024-06-03 12:38 ` Aubin Constans
2024-06-03 17:25 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032753-probable-blatancy-80bf@gregkh \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Eugeniy.Paltsev@synopsys$(echo .)com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=HaraldWelte@viatech$(echo .)com \
--cc=afaerber@suse$(echo .)de \
--cc=andersson@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=apais@linux$(echo .)microsoft.com \
--cc=asahi@lists$(echo .)linux.dev \
--cc=aubin.constans@microchip$(echo .)com \
--cc=baolin.wang@linux$(echo .)alibaba.com \
--cc=brucechang@via$(echo .)com.tw \
--cc=daniel@zonque$(echo .)org \
--cc=decui@microsoft$(echo .)com \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=duncan.sands@free$(echo .)fr \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=haijie1@huawei$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=haojian.zhuang@gmail$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jh80.chung@samsung$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=konrad.dybcio@linaro$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-actions@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=logang@deltatee$(echo .)com \
--cc=maintainers@bluecherrydvr$(echo .)com \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=manuel.lauss@gmail$(echo .)com \
--cc=marcan@marcan$(echo .)st \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mhiramat@kernel$(echo .)org \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oakad@yahoo$(echo .)com \
--cc=oneukum@suse$(echo .)com \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=orsonzhai@gmail$(echo .)com \
--cc=patrice.chotard@foss$(echo .)st.com \
--cc=paul@crapouillou$(echo .)net \
--cc=peter.ujfalusi@gmail$(echo .)com \
--cc=pierre@ossman$(echo .)eu \
--cc=rjui@broadcom$(echo .)com \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sbranden@broadcom$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=sven@svenpeter$(echo .)dev \
--cc=tj@kernel$(echo .)org \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vireshk@kernel$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
--cc=wangzhou1@hisilicon$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=zhang.lyra@gmail$(echo .)com \
--cc=zw@zh-kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox