Subject: Re: [PATCH net-next 7/8] net/mlx5e: XDP, Fix an inconsistent comment

From: Simon Horman <[email-masked]>
Date: Thu, 28 Mar 2024 11:17:55 +0000

On Wed, Mar 27, 2024 at 12:20:21AM +0200, Tariq Toukan wrote:
> From: Carolina Jubran <[email-masked]>
> 
> Since sinfo is no longer passed as an argument to
> mlx5e_xmit_xdp_frame(), the comment is inconsistent.
> 
> check_result must be zero when the packet is fragmented.
> 
> Signed-off-by: Carolina Jubran <[email-masked]>
> Reviewed-by: Tariq Toukan <[email-masked]>
> Signed-off-by: Saeed Mahameed <[email-masked]>
> Signed-off-by: Tariq Toukan <[email-masked]>

Hi Carolina and Tariq,

This looks good to me, but if there is a need to repost for some
other reason perhaps it would be worth mentioning that the commit
where the sinfo parameter was removed from mlx5e_xmit_xdp_frame()
was:

eb9b9fdcafe2 ("net/mlx5e: Introduce extended version for mlx5e_xmit_data")

That notwithstanding,

Reviewed-by: Simon Horman <[email-masked]>