Subject: Re: [PATCH net-next 5/8] net/mlx5e: Expose the VF/SF RX drop counter on the representor

From: Simon Horman <[email-masked]>
Date: Thu, 28 Mar 2024 11:18:31 +0000

On Wed, Mar 27, 2024 at 12:20:19AM +0200, Tariq Toukan wrote:
> From: Carolina Jubran <[email-masked]>
> 
> Q counters are device-level counters that track specific
> events, among which are out_of_buffer events. These events
> occur when packets are dropped due to a lack of receive
> buffer in the RX queue.
> 
> Expose the total number of out_of_buffer events on the
> VF/SF to their respective representor, using the
> "ethtool -S" under the name of "rx_vport_out_of_buffer".
> 
> The "rx_vport_out_of_buffer" equals the sum of all
> Q counters out_of_buffer values allocated on the VF/SF.

Hi Carolina and Tariq,

I am wondering if any consideration was given to making this
a generic counter. Buffer exhaustion sounds like something that
other NICs may report too.

> 
> Signed-off-by: Carolina Jubran <[email-masked]>
> Reviewed-by: Gal Pressman <[email-masked]>
> Reviewed-by: Aya Levin <[email-masked]>
> Signed-off-by: Tariq Toukan <[email-masked]>

...