Subject: Re: [PATCH net-next v2] devlink: use kvzalloc() to allocate devlink instance resources

From: Jakub Kicinski <[email-masked]>
Date: Thu, 28 Mar 2024 18:49:58 -0700

On Wed, 27 Mar 2024 11:15:08 +0100 Alexander Lobakin wrote:
> > Changes since v1:
> > - Use struct_size(devlink, priv, priv_size) as suggested by Alexander Lobakin

The change log should go under ---
and would be great to include a link to the previous version (from lore)

> > Signed-off-by: Jian Wen <[email-masked]>  
> 
> Since it actually fixes a bug splat, you may want to send it with prefix
> "net" instead of "net-next" and add a "Fixes:" tag here blaming the
> first commit which added Devlink instance allocation. Let's see what
> others think.

That's my initial reaction as well. We often treat memory
pressure improvements as fixes. But thinking more we would
need to check if any of the drivers puts a DMA buffer in its priv.
Some FW mailbox, maybe? It's possible.