Subject: Re: [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for PTP_PF_PEROUT

From: Jakub Kicinski <[email-masked]>
Date: Thu, 4 Apr 2024 09:41:37 -0700

On Thu, 4 Apr 2024 10:01:15 +0200 Horatiu Vultur wrote:
> +	if (period_nsec < 200) {
> +		pr_warn_ratelimited("%s: perout period too small, minimum is 200 nsec\n",
> +				    phydev_name(phydev));
> +		return -EOPNOTSUPP;
> +	}
> +
> +	if (on_nsec >= period_nsec) {
> +		pr_warn_ratelimited("%s: pulse width must be smaller than period\n",
> +				    phydev_name(phydev));
> +		return -EINVAL;
> +	}

-ENOUNLOCK brought to you by coccicheck:

drivers/net/phy/micrel.c:3049:2-8: preceding lock on line 3017
-- 
pw-bot: cr