Subject: Re: [PATCH net-next v2 3/5] net: stmmac: dwmac-socfpga: use pcs_init/pcs_exit

From: Jakub Kicinski <[email-masked]>
Date: Tue, 9 Apr 2024 18:34:04 -0700

On Tue, 09 Apr 2024 11:21:46 +0200 Romain Gantois wrote:
> +	struct regmap_config pcs_regmap_cfg = {
> +		.reg_bits = 16,
> +		.val_bits = 16,
> +		.reg_shift = regmap_upshift(1),

This appears to displease the compiler:

drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:389:16: error: call to undeclared function 'regmap_upshift'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  389 |                 .reg_shift = regmap_upshift(1),
      |                              ^
-- 
pw-bot: cr