Subject: Re: [PATCH net-next v10 2/6] net: stmmac: Add multi-channel support

From: Simon Horman <[email-masked]>
Date: Tue, 9 Apr 2024 19:55:08 +0100

On Tue, Apr 09, 2024 at 10:00:02PM +0800, Yanteng Si wrote:
> DW GMAC v3.x multi-channels feature is implemented as multiple
> sets of the same CSRs. Here is only preliminary support, it will
> be useful for the driver further evolution and for the users
> having multi-channel DWGMAC v3.x devices.
> 
> Signed-off-by: Feiyang Chen <[email-masked]>
> Signed-off-by: Yinggang Gu <[email-masked]>
> Signed-off-by: Yanteng Si <[email-masked]>

...

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index e1537a57815f..e94faa72f30e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -420,6 +420,12 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev,
>  		return 0;
>  	}
>  
> +	if (priv->plat->flags & STMMAC_FLAG_DISABLE_FORCE_1000) {

Hi Yanteng Si, Yanteng Si, all,

STMMAC_FLAG_DISABLE_FORCE_1000 is used here but it is not defined
until PATCH 6/6. This breaks bisection.

I expect this can be resolved by defining STMMAC_FLAG_DISABLE_FORCE_1000
as part of this patch.

> +		if (cmd->base.speed == SPEED_1000 &&
> +		    cmd->base.autoneg != AUTONEG_ENABLE)
> +			return -EOPNOTSUPP;
> +	}
> +
>  	return phylink_ethtool_ksettings_set(priv->phylink, cmd);
>  }
>  

-- 
pw-bot: changes-requested