Subject: Re: [PATCH iwl-next] ice: Deduplicate tc action setup

From: Simon Horman <[email-masked]>
Date: Tue, 16 Apr 2024 12:22:31 +0100

On Mon, Apr 15, 2024 at 10:49:07AM +0200, Marcin Szycik wrote:
> ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost
> identical, except for setting filter action. Reduce them to one function
> with an extra param, which handles both cases.
> 
> Reviewed-by: Mateusz Polchlopek <[email-masked]>
> Signed-off-by: Marcin Szycik <[email-masked]>
> ---
>  drivers/net/ethernet/intel/ice/ice_tc_lib.c | 56 ++++++---------------
>  1 file changed, 15 insertions(+), 41 deletions(-)

Less is more :)

Reviewed-by: Simon Horman <[email-masked]>