Subject: Re: [PATCH net] r8169: fix LED-related deadlock on module removal

From: Jakub Kicinski <[email-masked]>
Date: Tue, 16 Apr 2024 19:34:58 -0700

On Mon, 15 Apr 2024 13:57:17 +0200 Heiner Kallweit wrote:
> Binding devm_led_classdev_register() to the netdev is problematic
> because on module removal we get a RTNL-related deadlock. Fix this
> by avoiding the device-managed LED functions.
> 
> Note: We can safely call led_classdev_unregister() for a LED even
> if registering it failed, because led_classdev_unregister() detects
> this and is a no-op in this case.
> 
> Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101")
> Cc: <[email-masked]> # 6.8.x
> Reported-by: Lukas Wunner <[email-masked]>
> Signed-off-by: Heiner Kallweit <[email-masked]>

Looks like I already applied one chunk of this as commit 97e176fcbbf3
("r8169: add missing conditional compiling for call to r8169_remove_leds")
Is it worth throwing that in as a Fixes tag?