Subject: Re: [PATCH] m_ife: Remove unused value

From: Stephen Hemminger <[email-masked]>
Date: Wed, 17 Apr 2024 15:30:07 -0700

On Wed, 17 Apr 2024 20:08:55 +0300
Maks Mishin <[email-masked]> wrote:

> >                 ife_type = rta_getattr_u16(tb[TCA_IFE_TYPE]);
> > -               has_optional = 1;
> >                 print_0xhex(PRINT_ANY, "type", "type %#llX ", ife_type);
> >         }
> >
> > -       if (has_optional)
> > -               print_string(PRINT_FP, NULL, "%s\t", _SL_);
> > -

It is used. The printout would change with your patch. It would cause more
things to be one line.

The lower two has_optional parts have no effect and could be removed.

But before removing them, it would to look back in older versions
of iproute2 before JSON was introduced to see if this was something
that got mangled then.