From: Jason Xing <kerneljasonxing@gmail•com>
To: edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
davem@davemloft•net, horms@kernel•org
Cc: netdev@vger•kernel.org, kerneljasonxing@gmail•com,
Jason Xing <kernelxing@tencent•com>
Subject: [PATCH net-next v3 0/3] locklessly protect left members in struct rps_dev_flow
Date: Thu, 18 Apr 2024 15:36:00 +0800 [thread overview]
Message-ID: <20240418073603.99336-1-kerneljasonxing@gmail.com> (raw)
From: Jason Xing <kernelxing@tencent•com>
Since Eric did a more complicated locklessly change to last_qtail
member[1] in struct rps_dev_flow, the left members are easier to change
as the same.
One thing important I would like to share by qooting Eric:
"rflow is located in rxqueue->rps_flow_table, it is thus private to current
thread. Only one cpu can service an RX queue at a time."
So we only pay attention to the reader in the rps_may_expire_flow() and
writer in the set_rps_cpu(). They are in the two different contexts.
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=3b4cf29bdab
v3
Link: https://lore.kernel.org/all/20240417062721.45652-1-kerneljasonxing@gmail.com/
1. adjust the protection in a right way (Eric)
v2
1. fix passing wrong type qtail.
Jason Xing (3):
net: rps: protect last_qtail with rps_input_queue_tail_save() helper
net: rps: protect filter locklessly
net: rps: locklessly access rflow->cpu
net/core/dev.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--
2.37.3
next reply other threads:[~2024-04-18 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:36 Jason Xing [this message]
2024-04-18 7:36 ` [PATCH net-next v3 1/3] net: rps: protect last_qtail with rps_input_queue_tail_save() helper Jason Xing
2024-04-19 5:57 ` Eric Dumazet
2024-05-29 20:34 ` compile error in set_rps_cpu() without CONFIG_RFS_ACCEL? John Sperbeck
2024-05-29 20:45 ` Eric Dumazet
2024-05-30 2:56 ` Jason Xing
2024-05-30 2:55 ` Jason Xing
2024-04-18 7:36 ` [PATCH net-next v3 2/3] net: rps: protect filter locklessly Jason Xing
2024-04-19 5:58 ` Eric Dumazet
2024-04-18 7:36 ` [PATCH net-next v3 3/3] net: rps: locklessly access rflow->cpu Jason Xing
2024-04-19 5:58 ` Eric Dumazet
2024-04-19 10:40 ` [PATCH net-next v3 0/3] locklessly protect left members in struct rps_dev_flow patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418073603.99336-1-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kernelxing@tencent$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox