Subject: Re: [PATCH net-next v1 3/5] net: tn40xx: add basic Tx handling

From: Simon Horman <[email-masked]>
Date: Thu, 18 Apr 2024 18:24:15 +0100

On Thu, Apr 18, 2024 at 06:23:06PM +0100, Simon Horman wrote:
> On Mon, Apr 15, 2024 at 07:43:50PM +0900, FUJITA Tomonori wrote:
> > This patch adds device specific structures to initialize the hardware
> > with basic Tx handling. The original driver loads the embedded
> > firmware in the header file. This driver is implemented to use the
> > firmware APIs.
> > 
> > The Tx logic uses three major data structures; two ring buffers with
> > NIC and one database. One ring buffer is used to send information
> > about packets to be sent for NIC. The other is used to get information
> > from NIC about packet that are sent. The database is used to keep the
> > information about DMA mapping. After a packet is sent, the db is used
> > to free the resource used for the packet.
> > 
> > Signed-off-by: FUJITA Tomonori <[email-masked]>
> 
> Hi Fujita-san,
> 
> Some review from my side.
> 
> > ---
> >  drivers/net/ethernet/tehuti/Kconfig |    1 +
> >  drivers/net/ethernet/tehuti/tn40.c  | 1251 +++++++++++++++++++++++++++
> >  drivers/net/ethernet/tehuti/tn40.h  |  192 +++-
> >  3 files changed, 1443 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/tehuti/Kconfig b/drivers/net/ethernet/tehuti/Kconfig
> > index 849e3b4a71c1..4198fd59e42e 100644
> > --- a/drivers/net/ethernet/tehuti/Kconfig
> > +++ b/drivers/net/ethernet/tehuti/Kconfig
> > @@ -26,6 +26,7 @@ config TEHUTI
> >  config TEHUTI_TN40
> >  	tristate "Tehuti Networks TN40xx 10G Ethernet adapters"
> >  	depends on PCI
> > +	select FW_LOADER
> >  	help
> >  	  This driver supports 10G Ethernet adapters using Tehuti Networks
> >  	  TN40xx chips. Currently, adapters with Applied Micro Circuits
> 
> Not strictly related to this patch, but did you consider
> adding an entry in the MAINTAINERS file for this driver?

Sorry, somehow I missed that you have done that elsewhere
in this patchset.