Subject: Re: [PATCH net v2 2/3] mlxsw: core_env: Fix driver initialization with old firmware

From: Simon Horman <[email-masked]>
Date: Thu, 18 Apr 2024 18:55:34 +0100

On Thu, Apr 18, 2024 at 03:46:07PM +0200, Petr Machata wrote:
> From: Ido Schimmel <[email-masked]>
> 
> The driver queries the Management Capabilities Mask (MCAM) register
> during initialization to understand if it can read up to 128 bytes from
> transceiver modules.
> 
> However, not all firmware versions support this register, leading to the
> driver failing to load.
> 
> Fix by treating an error in the register query as an indication that the
> feature is not supported.
> 
> Fixes: 1f4aea1f72da ("mlxsw: core_env: Read transceiver module EEPROM in 128 bytes chunks")
> Cc: Simon Horman <[email-masked]>
> Reported-by: Tim 'mithro' Ansell <[email-masked]>
> Signed-off-by: Ido Schimmel <[email-masked]>
> Reviewed-by: Petr Machata <[email-masked]>
> Signed-off-by: Petr Machata <[email-masked]>
> ---
> 
> Notes:
>     v2:
>     - Make mlxsw_env_max_module_eeprom_len_query() void

Thanks for the update.

Reviewed-by: Simon Horman <[email-masked]>