From: Simon Horman <horms@kernel•org>
To: Justin Chen <justin.chen@broadcom•com>
Cc: netdev@vger•kernel.org,
Florian Fainelli <florian.fainelli@broadcom•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
"open list:BROADCOM ASP 2.0 ETHERNET DRIVER"
<bcm-kernel-feedback-list@broadcom•com>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net v2] net: bcmasp: fix memory leak when bringing down interface
Date: Thu, 18 Apr 2024 19:33:25 +0100 [thread overview]
Message-ID: <20240418183325.GM3975545@kernel.org> (raw)
In-Reply-To: <20240418180541.2271719-1-justin.chen@broadcom.com>
On Thu, Apr 18, 2024 at 11:05:41AM -0700, Justin Chen wrote:
> When bringing down the TX rings we flush the rings but forget to
> reclaimed the flushed packets. This leads to a memory leak since we
> do not free the dma mapped buffers. This also leads to tx control
> block corruption when bringing down the interface for power
> management.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <justin.chen@broadcom•com>
> Acked-by: Florian Fainelli <florian.fainelli@broadcom•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-04-18 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 18:05 [PATCH net v2] net: bcmasp: fix memory leak when bringing down interface Justin Chen
2024-04-18 18:33 ` Simon Horman [this message]
2024-04-20 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418183325.GM3975545@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=justin.chen@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox