From: Jakub Kicinski <kuba@kernel•org>
To: Danielle Ratson <danieller@nvidia•com>
Cc: <netdev@vger•kernel.org>, <davem@davemloft•net>,
<edumazet@google•com>, <pabeni@redhat•com>, <corbet@lwn•net>,
<linux@armlinux•org.uk>, <sdf@google•com>,
<kory.maincent@bootlin•com>, <maxime.chevallier@bootlin•com>,
<vladimir.oltean@nxp•com>, <przemyslaw.kitszel@intel•com>,
<ahmed.zaki@intel•com>, <richardcochran@gmail•com>,
<shayagr@amazon•com>, <paul.greenwalt@intel•com>,
<jiri@resnulli•us>, <linux-doc@vger•kernel.org>,
<linux-kernel@vger•kernel.org>, <mlxsw@nvidia•com>,
<petrm@nvidia•com>, <idosch@nvidia•com>
Subject: Re: [PATCH net-next v4 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands
Date: Thu, 18 Apr 2024 18:59:35 -0700 [thread overview]
Message-ID: <20240418185935.2b0ec734@kernel.org> (raw)
In-Reply-To: <20240418103455.3297870-8-danieller@nvidia.com>
On Thu, 18 Apr 2024 13:34:52 +0300 Danielle Ratson wrote:
> +static inline u16
> +cmis_cdb_module_features_completion_time(struct cmis_cdb_module_features_rpl *rpl)
> +{
> + return be16_to_cpu(rpl->max_completion_time);
> +}
nit: please drop all the inline in this file, the compiler will 100%
inline this anyway
next prev parent reply other threads:[~2024-04-19 1:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 10:34 [PATCH net-next v4 00/10] Add ability to flash modules' firmware Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 01/10] ethtool: Add ethtool operation to write to a transceiver module EEPROM Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 02/10] mlxsw: Implement " Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 03/10] ethtool: Add an interface for flashing transceiver modules' firmware Danielle Ratson
2024-04-19 2:07 ` Jakub Kicinski
2024-04-18 10:34 ` [PATCH net-next v4 04/10] ethtool: Add flashing transceiver modules' firmware notifications ability Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 05/10] include: netdevice: Add module firmware flashing in progress flag to net_device Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 06/10] net: sfp: Add more extended compliance codes Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands Danielle Ratson
2024-04-19 1:59 ` Jakub Kicinski [this message]
2024-04-18 10:34 ` [PATCH net-next v4 08/10] ethtool: cmis_fw_update: add a layer for supporting firmware update using CDB Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 09/10] ethtool: Add ability to flash transceiver modules' firmware Danielle Ratson
2024-04-18 10:34 ` [PATCH net-next v4 10/10] ethtool: Veto some operations during firmware flashing process Danielle Ratson
2024-04-19 2:10 ` [PATCH net-next v4 00/10] Add ability to flash modules' firmware Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418185935.2b0ec734@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paul.greenwalt@intel$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox