From: Heiko Carstens <hca@linux•ibm.com>
To: Bui Quang Minh <minhquangbui99@gmail•com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel•com>,
Rasesh Mody <rmody@marvell•com>,
Sudarsana Kalluru <skalluru@marvell•com>,
GR-Linux-NIC-Dev@marvell•com,
Anil Gurumurthy <anil.gurumurthy@qlogic•com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic•com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Fabian Frederick <fabf@skynet•be>,
Saurav Kashyap <skashyap@marvell•com>,
GR-QLogic-Storage-Upstream@marvell•com,
Nilesh Javali <nilesh.javali@cavium•com>,
Arun Easi <arun.easi@cavium•com>,
Manish Rangankar <manish.rangankar@cavium•com>,
Vineeth Vijayan <vneethv@linux•ibm.com>,
Peter Oberparleiter <oberpar@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Sven Schnelle <svens@linux•ibm.com>,
Sunil Goutham <sgoutham@marvell•com>,
Linu Cherian <lcherian@marvell•com>,
Geetha sowjanya <gakula@marvell•com>,
Jerin Jacob <jerinj@marvell•com>, hariprasad <hkelam@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-scsi@vger•kernel.org,
Saurav Kashyap <saurav.kashyap@cavium•com>,
linux-s390@vger•kernel.org, Jens Axboe <axboe@kernel•dk>
Subject: Re: [PATCH v2 5/6] cio: ensure the copied buf is NUL terminated
Date: Wed, 24 Apr 2024 16:54:05 +0200 [thread overview]
Message-ID: <20240424145405.26193-C-hca@linux.ibm.com> (raw)
In-Reply-To: <20240424-fix-oob-read-v2-5-f1f1b53a10f4@gmail.com>
On Wed, Apr 24, 2024 at 09:44:22PM +0700, Bui Quang Minh wrote:
> Currently, we allocate a lbuf-sized kernel buffer and copy lbuf from
> userspace to that buffer. Later, we use scanf on this buffer but we don't
> ensure that the string is terminated inside the buffer, this can lead to
> OOB read when using scanf. Fix this issue by using memdup_user_nul instead.
>
> Fixes: a4f17cc72671 ("s390/cio: add CRW inject functionality")
> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail•com>
> ---
> drivers/s390/cio/cio_inject.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Carstens <hca@linux•ibm.com>
next prev parent reply other threads:[~2024-04-24 14:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:44 [PATCH v2 0/6] Ensure the copied buf is NUL terminated Bui Quang Minh
2024-04-24 14:44 ` [PATCH v2 1/6] ice: ensure " Bui Quang Minh
2024-04-24 14:44 ` [PATCH v2 2/6] bna: " Bui Quang Minh
2024-04-24 14:44 ` [PATCH v2 3/6] bfa: " Bui Quang Minh
2024-05-07 1:19 ` Martin K. Petersen
2024-04-24 14:44 ` [PATCH v2 4/6] qedf: " Bui Quang Minh
2024-05-07 1:20 ` Martin K. Petersen
2024-04-24 14:44 ` [PATCH v2 5/6] cio: " Bui Quang Minh
2024-04-24 14:54 ` Heiko Carstens [this message]
2024-04-24 15:16 ` Alexander Gordeev
2024-04-26 10:10 ` Alexander Gordeev
2024-04-26 14:29 ` Jakub Kicinski
2024-04-24 14:44 ` [PATCH v2 6/6] octeontx2-af: avoid off-by-one read from userspace Bui Quang Minh
2024-04-26 2:30 ` [PATCH v2 0/6] Ensure the copied buf is NUL terminated patchwork-bot+netdevbpf
2024-05-11 18:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424145405.26193-C-hca@linux.ibm.com \
--to=hca@linux$(echo .)ibm.com \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=GR-QLogic-Storage-Upstream@marvell$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=anil.gurumurthy@qlogic$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arun.easi@cavium$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fabf@skynet$(echo .)be \
--cc=gakula@marvell$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hkelam@marvell$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jerinj@marvell$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lcherian@marvell$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=manish.rangankar@cavium$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=minhquangbui99@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nilesh.javali@cavium$(echo .)com \
--cc=oberpar@linux$(echo .)ibm.com \
--cc=pabeni@redhat$(echo .)com \
--cc=paul.m.stillwell.jr@intel$(echo .)com \
--cc=rmody@marvell$(echo .)com \
--cc=saurav.kashyap@cavium$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=skalluru@marvell$(echo .)com \
--cc=skashyap@marvell$(echo .)com \
--cc=sudarsana.kalluru@qlogic$(echo .)com \
--cc=svens@linux$(echo .)ibm.com \
--cc=vneethv@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox