From: Jakub Kicinski <kuba@kernel•org>
To: Lukasz Majewski <lukma@denx•de>
Cc: netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
Casper Andersson <casper.casan@gmail•com>,
Andrew Lunn <andrew@lunn•ch>, Eric Dumazet <edumazet@google•com>,
Vladimir Oltean <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Oleksij Rempel <o.rempel@pengutronix•de>,
Tristram.Ha@microchip•com,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Ravi Gunasekaran <r-gunasekaran@ti•com>,
Simon Horman <horms@kernel•org>,
Nikita Zhandarovich <n.zhandarovich@fintech•ru>,
Murali Karicheri <m-karicheri2@ti•com>,
Jiri Pirko <jiri@resnulli•us>,
Dan Carpenter <dan.carpenter@linaro•org>,
Ziyang Xuan <william.xuanziyang@huawei•com>,
Shigeru Yoshida <syoshida@redhat•com>,
"Ricardo B. Marliere" <ricardo@marliere•net>,
linux-kernel@vger•kernel.org
Subject: Re: [net-next PATCH] hsr: Simplify code for announcing HSR nodes timer setup
Date: Fri, 26 Apr 2024 17:33:17 -0700 [thread overview]
Message-ID: <20240426173317.2f6228a0@kernel.org> (raw)
In-Reply-To: <20240425153958.2326772-1-lukma@denx.de>
On Thu, 25 Apr 2024 17:39:58 +0200 Lukasz Majewski wrote:
> Up till now the code to start HSR announce timer, which triggers sending
> supervisory frames, was assuming that hsr_netdev_notify() would be called
> at least twice for hsrX interface. This was required to have different
> values for old and current values of network device's operstate.
>
> This is problematic for a case where hsrX interface is already in the
> operational state when hsr_netdev_notify() is called, so timer is not
> configured to trigger and as a result the hsrX is not sending supervisory
> frames to HSR ring.
>
> This error has been discovered when hsr_ping.sh script was run. To be
> more specific - for the hsr1 and hsr2 the hsr_netdev_notify() was
> called at least twice with different IF_OPER_{LOWERDOWN|DOWN|UP} states
> assigned in hsr_check_carrier_and_operstate(hsr). As a result there was
> no issue with sending supervisory frames.
> However, with hsr3, the notify function was called only once with
> operstate set to IF_OPER_UP and timer responsible for triggering
> supervisory frames was not fired.
>
> The solution is to use netif_oper_up() helper function to assess if
> network device is up and then setup timer. Otherwise the timer is
> activated.
NETDEV_CHANGE can get called for multiple trivial reasons, if the timer
is already running we'll mess with the spacing of the frames, no?
If there is a path where the device may get activated without the
notifier firing - maybe we can check carrier there and schedule the
timer?
Also sounds like a bug fix, so please add a Fixes tag.
next prev parent reply other threads:[~2024-04-27 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 15:39 [net-next PATCH] hsr: Simplify code for announcing HSR nodes timer setup Lukasz Majewski
2024-04-27 0:33 ` Jakub Kicinski [this message]
2024-04-29 10:09 ` Lukasz Majewski
2024-04-29 17:40 ` Jakub Kicinski
2024-04-30 12:52 ` Lukasz Majewski
2024-04-30 14:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426173317.2f6228a0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Tristram.Ha@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bigeasy@linutronix$(echo .)de \
--cc=casper.casan@gmail$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jiri@resnulli$(echo .)us \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lukma@denx$(echo .)de \
--cc=m-karicheri2@ti$(echo .)com \
--cc=n.zhandarovich@fintech$(echo .)ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=r-gunasekaran@ti$(echo .)com \
--cc=ricardo@marliere$(echo .)net \
--cc=syoshida@redhat$(echo .)com \
--cc=william.xuanziyang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox