From: Simon Horman <horms@kernel•org>
To: MD Danish Anwar <danishanwar@ti•com>
Cc: Dan Carpenter <dan.carpenter@linaro•org>,
Heiner Kallweit <hkallweit1@gmail•com>,
Andrew Lunn <andrew@lunn•ch>, Jan Kiszka <jan.kiszka@siemens•com>,
Diogo Ivo <diogo.ivo@siemens•com>,
Paolo Abeni <pabeni@redhat•com>, Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
"David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, srk@ti•com,
Vignesh Raghavendra <vigneshr@ti•com>,
r-gunasekaran@ti•com, Roger Quadros <rogerq@kernel•org>
Subject: Re: [PATCH net-next v3] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers
Date: Tue, 30 Apr 2024 20:49:38 +0100 [thread overview]
Message-ID: <20240430194938.GD2575892@kernel.org> (raw)
In-Reply-To: <20240430120634.1558998-1-danishanwar@ti.com>
On Tue, Apr 30, 2024 at 05:36:34PM +0530, MD Danish Anwar wrote:
> Add SW IRQ coalescing based on hrtimers for RX and TX data path for ICSSG
> driver, which can be enabled by ethtool commands:
>
> - RX coalescing
> ethtool -C eth1 rx-usecs 50
>
> - TX coalescing can be enabled per TX queue
>
> - by default enables coalescing for TX0
> ethtool -C eth1 tx-usecs 50
> - configure TX0
> ethtool -Q eth0 queue_mask 1 --coalesce tx-usecs 100
> - configure TX1
> ethtool -Q eth0 queue_mask 2 --coalesce tx-usecs 100
> - configure TX0 and TX1
> ethtool -Q eth0 queue_mask 3 --coalesce tx-usecs 100 --coalesce
> tx-usecs 100
>
> Minimum value for both rx-usecs and tx-usecs is 20us.
>
> Compared to gro_flush_timeout and napi_defer_hard_irqs this patch allows
> to enable IRQ coalescing for RX path separately.
>
> Benchmarking numbers:
> ===============================================================
> | Method | Tput_TX | CPU_TX | Tput_RX | CPU_RX |
> | ==============================================================
> | Default Driver 943 Mbps 31% 517 Mbps 38% |
> | IRQ Coalescing (Patch) 943 Mbps 28% 518 Mbps 25% |
> ===============================================================
>
> Signed-off-by: MD Danish Anwar <danishanwar@ti•com>
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
> ---
> Changes from v2 [2] to v3:
> *) Collected RB tag from Andrew Lunn <andrew@lunn•ch>
> *) Fixed warning caused by {} missing for outer if conditions in
> emac_napi_tx_poll() and emac_napi_rx_poll() APIs.
> *) Fixed spelling mistake.
Thanks for the updates.
This one looks good to me.
Reviewed-by: Simon Horman <horms@kernel•org>
>
> Changes from v1 [1] to v2:
> *) Added Benchmarking numbers in the commit message as suggested by
> Andrew Lunn <andrew@lunn•ch>. Full logs [3]
> *) Addressed comments given by Simon Horman <horms@kernel•org> in v1.
>
> [1] https://lore.kernel.org/all/20240424091823.1814136-1-danishanwar@ti.com/
> [2] https://lore.kernel.org/all/20240429071501.547680-1-danishanwar@ti.com/
> [3] https://gist.githubusercontent.com/danish-ti/47855631be9f3635cee994693662a988/raw/94b4eb86b42fe243ab03186a88a314e0cb272fd0/gistfile1.txt
...
next prev parent reply other threads:[~2024-04-30 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:06 [PATCH net-next v3] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers MD Danish Anwar
2024-04-30 19:49 ` Simon Horman [this message]
2024-05-02 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430194938.GD2575892@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=diogo.ivo@siemens$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jan.kiszka@siemens$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=r-gunasekaran@ti$(echo .)com \
--cc=rogerq@kernel$(echo .)org \
--cc=srk@ti$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox