From: "Michael S. Tsirkin" <mst@redhat•com>
To: Heng Qi <hengqi@linux•alibaba.com>
Cc: Jakub Kicinski <kuba@kernel•org>,
kernel test robot <lkp@intel•com>,
oe-kbuild-all@lists•linux.dev,
"David S . Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Jason Wang <jasowang@redhat•com>,
Brett Creeley <bcreeley@amd•com>,
Ratheesh Kannoth <rkannoth@marvell•com>,
Alexander Lobakin <aleksander.lobakin@intel•com>,
Xuan Zhuo <xuanzhuo@linux•alibaba.com>,
Tal Gilboa <talgi@nvidia•com>, Jonathan Corbet <corbet@lwn•net>,
linux-doc@vger•kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Jiri Pirko <jiri@resnulli•us>,
Paul Greenwalt <paul.greenwalt@intel•com>,
Ahmed Zaki <ahmed.zaki@intel•com>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Kory Maincent <kory.maincent@bootlin•com>,
Andrew Lunn <andrew@lunn•ch>,
justinstitt@google•com, netdev@vger•kernel.org,
virtualization@lists•linux.dev
Subject: Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management
Date: Wed, 1 May 2024 11:48:23 -0400 [thread overview]
Message-ID: <20240501114754-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1714576307.2126026-2-hengqi@linux.alibaba.com>
On Wed, May 01, 2024 at 11:11:47PM +0800, Heng Qi wrote:
> On Wed, 1 May 2024 07:44:20 -0700, Jakub Kicinski <kuba@kernel•org> wrote:
> > On Wed, 1 May 2024 12:45:36 +0800 Heng Qi wrote:
> > > > net/ethtool/coalesce.c: At top level:
> > > [...]
> > > > 446 | static int ethnl_update_profile(struct net_device *dev,
> > > > | ^~~~~~~~~~~~~~~~~~~~
> > > [...]
> > > > 151 | static int coalesce_put_profile(struct sk_buff *skb, u16 attr_type,
> > > > | ^~~~~~~~~~~~~~~~~~~~
> > > >
> > >
> > > This is a known minor issue, to reduce the use of 'IS_ENABLED(CONFIG_DIMLIB)'
> > > mentioned in v10. Since the calls of ethnl_update_profile() and
> > > coalesce_put_profile() will only occur when IS_ENABLED(CONFIG_DIMLIB) returns
> > > true, the robot's warning can be ignored the code is safe.
> > >
> > > All NIPA test cases running on my local pass successfully on V11.
> > >
> > > Alternatively, I remake the series to have IS_ENABLED(CONFIG_DIMLIB) back,
> > > up to Kuba (and others). :)
> >
> > You should remove the ifdef around the member in struct net_device.
> > It's too much code complication to save one pointer in the struct.
>
> Makes sense.
>
> Thanks.
if you really want to you can add a comment
/* only used if IS_ENABLED(CONFIG_DIMLIB) */
next prev parent reply other threads:[~2024-05-01 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 17:31 [PATCH net-next v11 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-04-30 17:31 ` [PATCH net-next v11 1/4] linux/dim: move useful macros to .h file Heng Qi
2024-04-30 17:31 ` [PATCH net-next v11 2/4] ethtool: provide customized dim profile management Heng Qi
2024-05-01 2:36 ` kernel test robot
2024-05-01 4:45 ` Heng Qi
2024-05-01 5:55 ` Michael S. Tsirkin
2024-05-01 14:44 ` Jakub Kicinski
2024-05-01 15:11 ` Heng Qi
2024-05-01 15:48 ` Michael S. Tsirkin [this message]
2024-05-01 16:19 ` Heng Qi
2024-05-01 8:06 ` kernel test robot
2024-05-01 8:27 ` kernel test robot
2024-05-03 13:52 ` Simon Horman
2024-05-04 6:32 ` Heng Qi
2024-04-30 17:31 ` [PATCH net-next v11 3/4] dim: add new interfaces for initialization and getting results Heng Qi
2024-04-30 17:31 ` [PATCH net-next v11 4/4] virtio-net: support dim profile fine-tuning Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501114754-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bcreeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hengqi@linux$(echo .)alibaba.com \
--cc=jasowang@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=justinstitt@google$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=paul.greenwalt@intel$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=talgi@nvidia$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox