From: Simon Horman <horms@kernel•org>
To: Xin Long <lucien.xin@gmail•com>
Cc: network dev <netdev@vger•kernel.org>,
tipc-discussion@lists•sourceforge.net, davem@davemloft•net,
kuba@kernel•org, Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Jon Maloy <jmaloy@redhat•com>,
Ying Xue <ying.xue@windriver•com>,
Tung Nguyen <tung.q.nguyen@dektech•com.au>
Subject: Re: [PATCH net] tipc: fix a possible memleak in tipc_buf_append
Date: Wed, 1 May 2024 16:15:17 +0100 [thread overview]
Message-ID: <20240501151517.GT2575892@kernel.org> (raw)
In-Reply-To: <90710748c29a1521efac4f75ea01b3b7e61414cf.1714485818.git.lucien.xin@gmail.com>
On Tue, Apr 30, 2024 at 10:03:38AM -0400, Xin Long wrote:
> __skb_linearize() doesn't free the skb when it fails, so move
> '*buf = NULL' after __skb_linearize(), so that the skb can be
> freed on the err path.
>
> Fixes: b7df21cf1b79 ("tipc: skb_linearize the head skb when reassembling msgs")
> Reported-by: Paolo Abeni <pabeni@redhat•com>
> Signed-off-by: Xin Long <lucien.xin@gmail•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-05-01 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 14:03 [PATCH net] tipc: fix a possible memleak in tipc_buf_append Xin Long
2024-05-01 15:15 ` Simon Horman [this message]
2024-05-02 0:43 ` Tung Quang Nguyen
2024-05-02 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501151517.GT2575892@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jmaloy@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=tung.q.nguyen@dektech$(echo .)com.au \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox