Subject: Re: [PATCH net-next] selftests: netfilter: nft_concat_range.sh: reduce debug kernel run time

From: Florian Westphal <[email-masked]>
Date: Wed, 1 May 2024 21:41:53 +0200

Simon Horman <[email-masked]> wrote:
> On Tue, Apr 30, 2024 at 04:58:07PM +0200, Florian Westphal wrote:
> 
> ...
> 
> > diff --git a/tools/testing/selftests/net/netfilter/nft_concat_range.sh b/tools/testing/selftests/net/netfilter/nft_concat_range.sh
> 
> ...
> 
> > @@ -1584,10 +1594,16 @@ for name in ${TESTS}; do
> >  			continue
> >  		fi
> >  
> > -		printf "  %-60s  " "${display}"
> > +		[ "$KSFT_MACHINE_SLOW" = "yes" ] && count=1
> > +
> > +		printf "  %-32s  " "${display}"
> > +		tthen=$(date +%s)
> >  		eval test_"${name}"
> >  		ret=$?
> >  
> > +		tnow=$(date +%s)
> > +		printf "%5ds%-30s" $((tnow-tthen))
> > + 
> 
> Hi Florian,
> 
> A minor nit: the format string above expects two variables, but only one
> is passed.

Its intentional, I thought this was better than "%5ds                 "
or similar.