From: Jakub Kicinski <kuba@kernel•org>
To: Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
netdev@vger•kernel.org, Ngai-Mint Kwan <ngai-mint.kwan@intel•com>,
Mateusz Polchlopek <mateusz.polchlopek@intel•com>,
Pawel Chmielewski <pawel.chmielewski@intel•com>,
Simon Horman <horms@kernel•org>,
Dawid Osuchowski <dawid.osuchowski@linux•intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel•com>
Subject: Re: [PATCH net] ice: Do not get coalesce settings while in reset
Date: Wed, 1 May 2024 19:56:41 -0700 [thread overview]
Message-ID: <20240501195641.1e606747@kernel.org> (raw)
In-Reply-To: <20240430181434.1942751-1-anthony.l.nguyen@intel.com>
On Tue, 30 Apr 2024 11:14:32 -0700 Tony Nguyen wrote:
> Getting coalesce settings while reset is in progress can cause NULL
> pointer deference bug.
> If under reset, abort get coalesce for ethtool.
Did you not add locks around reset to allow waiting instead of returning
-EBUSY to user space? I feel like we've been over this...
next prev parent reply other threads:[~2024-05-02 2:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 18:14 [PATCH net] ice: Do not get coalesce settings while in reset Tony Nguyen
2024-05-02 2:56 ` Jakub Kicinski [this message]
2024-05-06 13:30 ` Dawid Osuchowski
2024-05-17 13:31 ` Dawid Osuchowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501195641.1e606747@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dawid.osuchowski@linux$(echo .)intel.com \
--cc=edumazet@google$(echo .)com \
--cc=himasekharx.reddy.pucha@intel$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=mateusz.polchlopek@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ngai-mint.kwan@intel$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pawel.chmielewski@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox