Subject: Re: [PATCH net-next v2 5/6] bnxt_en: Optimize recovery path ULP locking in the driver

From: Jakub Kicinski <[email-masked]>
Date: Thu, 2 May 2024 07:36:27 -0700

On Tue, 30 Apr 2024 17:30:55 -0700 Michael Chan wrote:
> Rely on the new en_dev_lock mutex instead for ULP_STOP and
> ULP_START.  For the most part, we move the ULP_STOP call before
> we take the RTNL lock and move the ULP_START after RTNL unlock.
> Note that SRIOV re-enablement must be done after ULP_START
> or RoCE on the VFs will not resume properly after reset.

The SRIOV locking looks quite questionable, but it seems to be
an existing problem.