Subject: Re: [PATCH net-next 2/2] IB/hfi1: Remove generic .ndo_get_stats64

From: Leon Romanovsky <[email-masked]>
Date: Sun, 5 May 2024 17:16:05 +0300

On Fri, May 03, 2024 at 04:13:32AM -0700, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
> 
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
> 
> Signed-off-by: Breno Leitao <[email-masked]>
> ---
>  drivers/infiniband/hw/hfi1/ipoib_main.c | 1 -
>  1 file changed, 1 deletion(-)

Dennis,

Please pay attention that 3e2f544dd8a33 ("net: get stats64 if device if
driver is configured") is not in RDMA tree yet, but we are approaching
merge window and linux-next is already have it.

Thanks

> 
> diff --git a/drivers/infiniband/hw/hfi1/ipoib_main.c b/drivers/infiniband/hw/hfi1/ipoib_main.c
> index 59c6e55f4119..7c9d5203002b 100644
> --- a/drivers/infiniband/hw/hfi1/ipoib_main.c
> +++ b/drivers/infiniband/hw/hfi1/ipoib_main.c
> @@ -96,7 +96,6 @@ static const struct net_device_ops hfi1_ipoib_netdev_ops = {
>  	.ndo_uninit       = hfi1_ipoib_dev_uninit,
>  	.ndo_open         = hfi1_ipoib_dev_open,
>  	.ndo_stop         = hfi1_ipoib_dev_stop,
> -	.ndo_get_stats64  = dev_get_tstats64,
>  };
>  
>  static int hfi1_ipoib_mcast_attach(struct net_device *dev,
> -- 
> 2.43.0
>