From: Kees Cook <keescook@chromium•org>
To: Edward Liaw <edliaw@google•com>
Cc: shuah@kernel•org, "Mark Brown" <broonie@kernel•org>,
"Jaroslav Kysela" <perex@perex•cz>,
"Takashi Iwai" <tiwai@suse•com>,
"Catalin Marinas" <catalin.marinas@arm•com>,
"Will Deacon" <will@kernel•org>, "Nhat Pham" <nphamcs@gmail•com>,
"Johannes Weiner" <hannes@cmpxchg•org>,
"Christian Brauner" <brauner@kernel•org>,
"Eric Biederman" <ebiederm@xmission•com>,
"OGAWA Hirofumi" <hirofumi@mail•parknet.co.jp>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Ingo Molnar" <mingo@redhat•com>,
"Peter Zijlstra" <peterz@infradead•org>,
"Darren Hart" <dvhart@infradead•org>,
"Davidlohr Bueso" <dave@stgolabs•net>,
"André Almeida" <andrealmeid@igalia•com>,
"Jiri Kosina" <jikos@kernel•org>,
"Benjamin Tissoires" <bentiss@kernel•org>,
"Jason Gunthorpe" <jgg@ziepe•ca>,
"Kevin Tian" <kevin.tian@intel•com>,
"Andy Lutomirski" <luto@amacapital•net>,
"Will Drewry" <wad@chromium•org>, "Marc Zyngier" <maz@kernel•org>,
"Oliver Upton" <oliver.upton@linux•dev>,
"James Morse" <james.morse@arm•com>,
"Suzuki K Poulose" <suzuki.poulose@arm•com>,
"Zenghui Yu" <yuzenghui@huawei•com>,
"Paolo Bonzini" <pbonzini@redhat•com>,
"Sean Christopherson" <seanjc@google•com>,
"Anup Patel" <anup@brainfault•org>,
"Atish Patra" <atishp@atishpatra•org>,
"Paul Walmsley" <paul.walmsley@sifive•com>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Albert Ou" <aou@eecs•berkeley.edu>,
"Christian Borntraeger" <borntraeger@linux•ibm.com>,
"Janosch Frank" <frankja@linux•ibm.com>,
"Claudio Imbrenda" <imbrenda@linux•ibm.com>,
"David Hildenbrand" <david@redhat•com>,
"Mickaël Salaün" <mic@digikod•net>,
"Paul Moore" <paul@paul-moore•com>,
"James Morris" <jmorris@namei•org>,
"Serge E. Hallyn" <serge@hallyn•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Seth Forshee" <sforshee@kernel•org>,
"Bongsu Jeon" <bongsu.jeon@samsung•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Steffen Klassert" <steffen.klassert@secunet•com>,
"Herbert Xu" <herbert@gondor•apana.org.au>,
"Andreas Färber" <afaerber@suse•de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro•org>,
"Matthieu Baerts" <matttbe@kernel•org>,
"Mat Martineau" <martineau@kernel•org>,
"Geliang Tang" <geliang@kernel•org>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail•com>,
"Fenghua Yu" <fenghua.yu@intel•com>,
"Reinette Chatre" <reinette.chatre@intel•com>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios•com>,
"Paul E. McKenney" <paulmck@kernel•org>,
"Boqun Feng" <boqun.feng@gmail•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Jarkko Sakkinen" <jarkko@kernel•org>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
"Muhammad Usama Anjum" <usama.anjum@collabora•com>,
linux-kernel@vger•kernel.org, linux-kselftest@vger•kernel.org,
kernel-team@android•com, linux-sound@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-mm@kvack•org,
linux-input@vger•kernel.org, iommu@lists•linux.dev,
kvmarm@lists•linux.dev, kvm@vger•kernel.org,
kvm-riscv@lists•infradead.org, linux-riscv@lists•infradead.org,
linux-security-module@vger•kernel.org,
linux-fsdevel@vger•kernel.org, netdev@vger•kernel.org,
linux-actions@lists•infradead.org, mptcp@lists•linux.dev,
linux-rtc@vger•kernel.org, linux-sgx@vger•kernel.org,
bpf@vger•kernel.org
Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using
Date: Tue, 7 May 2024 16:28:53 -0700 [thread overview]
Message-ID: <202405071628.7F8C3EC@keescook> (raw)
In-Reply-To: <20240507214254.2787305-1-edliaw@google.com>
On Tue, May 07, 2024 at 09:38:25PM +0000, Edward Liaw wrote:
> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced
> asprintf into kselftest_harness.h, which is a GNU extension and needs
> _GNU_SOURCE to either be defined prior to including headers or with the
> -D_GNU_SOURCE flag passed to the compiler.
>
> v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/
> v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single
> location. Remove #define _GNU_SOURCE from source code to resolve
> redefinition warnings.
>
> Edward Liaw (5):
> selftests: Compile kselftest headers with -D_GNU_SOURCE
> selftests/sgx: Include KHDR_INCLUDES in Makefile
> selftests: Include KHDR_INCLUDES in Makefile
> selftests: Drop define _GNU_SOURCE
> selftests: Drop duplicate -D_GNU_SOURCE
It's a lot of churn, but I don't see a way to do it differently. :)
Reviewed-by: Kees Cook <keescook@chromium•org>
--
Kees Cook
next prev parent reply other threads:[~2024-05-07 23:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 21:38 [PATCH v2 0/5] Define _GNU_SOURCE for sources using Edward Liaw
2024-05-07 21:38 ` [PATCH v2 1/5] selftests: Compile kselftest headers with -D_GNU_SOURCE Edward Liaw
2024-05-08 7:48 ` Muhammad Usama Anjum
2024-05-08 12:05 ` Mark Brown
2024-05-08 21:23 ` John Hubbard
2024-05-07 21:38 ` [PATCH v2 2/5] selftests/sgx: Include KHDR_INCLUDES in Makefile Edward Liaw
2024-05-08 7:49 ` Muhammad Usama Anjum
2024-05-08 15:33 ` Dave Hansen
2024-05-08 16:44 ` Jarkko Sakkinen
2024-05-08 21:25 ` John Hubbard
2024-05-07 21:38 ` [PATCH v2 3/5] selftests: " Edward Liaw
2024-05-07 22:36 ` Jarkko Sakkinen
2024-05-08 7:49 ` Muhammad Usama Anjum
2024-05-08 21:41 ` John Hubbard
2024-05-09 0:29 ` Edward Liaw
2024-05-09 1:03 ` John Hubbard
2024-05-09 5:14 ` Mark Brown
2024-05-07 21:38 ` [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE Edward Liaw
2024-05-08 7:50 ` Muhammad Usama Anjum
2024-05-08 13:54 ` Sean Christopherson
2024-05-08 20:27 ` Edward Liaw
2024-05-08 21:39 ` John Hubbard
2024-05-07 21:38 ` [PATCH v2 5/5] selftests: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-08 7:58 ` Muhammad Usama Anjum
2024-05-08 21:49 ` John Hubbard
2024-05-07 23:28 ` Kees Cook [this message]
2024-05-08 13:47 ` [PATCH v2 0/5] Define _GNU_SOURCE for sources using Sean Christopherson
2024-05-08 18:03 ` Edward Liaw
2024-05-08 23:10 ` Shuah Khan
2024-05-09 6:13 ` Edward Liaw
2024-05-09 14:37 ` Shuah Khan
2024-05-09 17:45 ` Edward Liaw
2024-05-09 18:20 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405071628.7F8C3EC@keescook \
--to=keescook@chromium$(echo .)org \
--cc=afaerber@suse$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrealmeid@igalia$(echo .)com \
--cc=anup@brainfault$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=atishp@atishpatra$(echo .)org \
--cc=bentiss@kernel$(echo .)org \
--cc=bongsu.jeon@samsung$(echo .)com \
--cc=boqun.feng@gmail$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brauner@kernel$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dave@stgolabs$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david@redhat$(echo .)com \
--cc=dvhart@infradead$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=edliaw@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=frankja@linux$(echo .)ibm.com \
--cc=geliang@kernel$(echo .)org \
--cc=hannes@cmpxchg$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hirofumi@mail$(echo .)parknet.co.jp \
--cc=imbrenda@linux$(echo .)ibm.com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=james.morse@arm$(echo .)com \
--cc=jarkko@kernel$(echo .)org \
--cc=jgg@ziepe$(echo .)ca \
--cc=jikos@kernel$(echo .)org \
--cc=jmorris@namei$(echo .)org \
--cc=kernel-team@android$(echo .)com \
--cc=kevin.tian@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvm-riscv@lists$(echo .)infradead.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-actions@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=linux-sgx@vger$(echo .)kernel.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=martineau@kernel$(echo .)org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=matttbe@kernel$(echo .)org \
--cc=maz@kernel$(echo .)org \
--cc=mic@digikod$(echo .)net \
--cc=mingo@redhat$(echo .)com \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nphamcs@gmail$(echo .)com \
--cc=oliver.upton@linux$(echo .)dev \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paul@paul-moore$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=peterz@infradead$(echo .)org \
--cc=reinette.chatre@intel$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=serge@hallyn$(echo .)com \
--cc=sforshee@kernel$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tiwai@suse$(echo .)com \
--cc=usama.anjum@collabora$(echo .)com \
--cc=wad@chromium$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=yuzenghui@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox