From: Simon Horman <horms@kernel•org>
To: Allen <allen.lkml@gmail•com>
Cc: "Russell King (Oracle)" <linux@armlinux•org.uk>,
Allen Pais <apais@linux•microsoft.com>,
netdev@vger•kernel.org, jes@trained-monkey•org,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, kda@linux-powerpc•org, cai.huoqing@linux•dev,
dougmill@linux•ibm.com, npiggin@gmail•com,
christophe.leroy@csgroup•eu, aneesh.kumar@kernel•org,
naveen.n.rao@linux•ibm.com, nnac123@linux•ibm.com,
tlfalcon@linux•ibm.com, cooldavid@cooldavid•org,
marcin.s.wojtas@gmail•com, mlindner@marvell•com,
stephen@networkplumber•org, nbd@nbd•name, sean.wang@mediatek•com,
Mark-MC.Lee@mediatek•com, lorenzo@kernel•org,
matthias.bgg@gmail•com, angelogioacchino.delregno@collabora•com,
borisp@nvidia•com, bryan.whitehead@microchip•com,
UNGLinuxDriver@microchip•com, louis.peens@corigine•com,
richardcochran@gmail•com, linux-rdma@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-acenic@sunsite•dk,
linux-arm-kernel@lists•infradead.org,
linuxppc-dev@lists•ozlabs.org,
linux-mediatek@lists•infradead.org, oss-drivers@corigine•com,
linux-net-drivers@amd•com
Subject: Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue
Date: Wed, 8 May 2024 21:16:54 +0100 [thread overview]
Message-ID: <20240508201654.GA2248333@kernel.org> (raw)
In-Reply-To: <CAOMdWSKfkT4K9MAOn-rL44pycHPhVDj4CtiYkru5y_s0S-sPeQ@mail.gmail.com>
On Tue, May 07, 2024 at 12:27:10PM -0700, Allen wrote:
> On Tue, May 7, 2024 at 12:23 PM Russell King (Oracle)
> <linux@armlinux•org.uk> wrote:
> >
> > On Tue, May 07, 2024 at 07:01:11PM +0000, Allen Pais wrote:
> > > The only generic interface to execute asynchronously in the BH context is
> > > tasklet; however, it's marked deprecated and has some design flaws. To
> > > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > > behaves similarly to regular workqueues except that the queued work items
> > > are executed in the BH context.
> > >
> > > This patch converts drivers/ethernet/* from tasklet to BH workqueue.
> >
> > I doubt you're going to get many comments on this patch, being so large
> > and spread across all drivers. I'm not going to bother trying to edit
> > this down to something more sensible, I'll just plonk my comment here.
> >
> > For the mvpp2 driver, you're only updating a comment - and looking at
> > it, the comment no longer reflects the code. It doesn't make use of
> > tasklets at all. That makes the comment wrong whether or not it's
> > updated. So I suggest rather than doing a search and replace for
> > "tasklet" to "BH blahblah" (sorry, I don't remember what you replaced
> > it with) just get rid of that bit of the comment.
> >
>
> Thank you Russell.
>
> I will get rid of the comment. If it helps, I can create a patch for each
> driver. We did that in the past, with this series, I thought it would be
> easier to apply one patch.
Hi Allen and Russell,
My 2c worth:
* In general non bug-fix patches for networking code should be targeted at
net-next. This means that they should include net-next in the subject,
and be based on that tree.
Subject: [PATCH net-next] ...
* This series does not appear to apply to net-next
* This series appears to depend on code which is not present in net-next.
f.e. disable_work_sync
* The Infiniband patches should probably be submitted separately
to the relevant maintainers
* As this patch seems to involve many non-trivial changes
it seems to me that it would be best to break it up somehow.
To allow proper review.
* Patch-sets for net-next should be limited to 15 patches,
so perhaps multiple sequential batches would be a way forwards.
Link: https://docs.kernel.org/process/maintainer-netdev.html
next prev parent reply other threads:[~2024-05-08 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 19:01 [PATCH 0/1] Convert tasklets to BH workqueues in ethernet drivers Allen Pais
2024-05-07 19:01 ` [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue Allen Pais
2024-05-07 19:22 ` Russell King (Oracle)
2024-05-07 19:27 ` Allen
2024-05-08 20:16 ` Simon Horman [this message]
2024-05-09 7:59 ` Paolo Abeni
2024-05-09 21:38 ` Allen
2024-05-09 21:35 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508201654.GA2248333@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Mark-MC.Lee@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=allen.lkml@gmail$(echo .)com \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=apais@linux$(echo .)microsoft.com \
--cc=borisp@nvidia$(echo .)com \
--cc=bryan.whitehead@microchip$(echo .)com \
--cc=cai.huoqing@linux$(echo .)dev \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=cooldavid@cooldavid$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dougmill@linux$(echo .)ibm.com \
--cc=edumazet@google$(echo .)com \
--cc=jes@trained-monkey$(echo .)org \
--cc=kda@linux-powerpc$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-acenic@sunsite$(echo .)dk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=louis.peens@corigine$(echo .)com \
--cc=marcin.s.wojtas@gmail$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mlindner@marvell$(echo .)com \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nnac123@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tlfalcon@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox