From: Jakub Kicinski <kuba@kernel•org>
To: Tao Su <tao1.su@linux•intel.com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
linux-kselftest@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-sound@vger•kernel.org, kvm@vger•kernel.org,
netdev@vger•kernel.org, linux-rtc@vger•kernel.org,
linux-sgx@vger•kernel.org, edliaw@google•com,
ivan.orlov0322@gmail•com, broonie@kernel•org, perex@perex•cz,
tiwai@suse•com, shuah@kernel•org, seanjc@google•com,
pbonzini@redhat•com, bongsu.jeon@samsung•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
alexandre.belloni@bootlin•com, jarkko@kernel•org,
dave.hansen@linux•intel.com
Subject: Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
Date: Thu, 9 May 2024 11:27:28 -0700 [thread overview]
Message-ID: <20240509112728.6670264c@kernel.org> (raw)
In-Reply-To: <ZjxaVEKv7bEuHJ8c@linux.bj.intel.com>
On Thu, 9 May 2024 13:08:36 +0800 Tao Su wrote:
> > SGTM, FWIW. The print is printing a test summary line, printing more
> > than 1k seems rather unreasonable. Other facilities, like TH_LOG(),
> > should be used for displaying longer info.
>
> Thanks, do you think 1k is enough for test_name?
Definitely.
prev parent reply other threads:[~2024-05-09 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 6:35 [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h Tao Su
2024-05-07 17:06 ` Andrew Morton
2024-05-08 2:55 ` Tao Su
2024-05-08 14:00 ` Jakub Kicinski
2024-05-08 17:57 ` Edward Liaw
2024-05-09 5:10 ` Tao Su
2024-05-09 5:08 ` Tao Su
2024-05-09 18:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509112728.6670264c@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=bongsu.jeon@samsung$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=edliaw@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=ivan.orlov0322@gmail$(echo .)com \
--cc=jarkko@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-sgx@vger$(echo .)kernel.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pbonzini@redhat$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=seanjc@google$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=tao1.su@linux$(echo .)intel.com \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox