From: Jakub Kicinski <kuba@kernel•org>
To: Heng Qi <hengqi@linux•alibaba.com>
Cc: kernel test robot <lkp@intel•com>,
llvm@lists•linux.dev, oe-kbuild-all@lists•linux.dev,
"David S . Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Jason Wang <jasowang@redhat•com>,
"Michael S . Tsirkin" <mst@redhat•com>,
Brett Creeley <bcreeley@amd•com>,
Ratheesh Kannoth <rkannoth@marvell•com>,
Alexander Lobakin <aleksander.lobakin@intel•com>,
Xuan Zhuo <xuanzhuo@linux•alibaba.com>,
Tal Gilboa <talgi@nvidia•com>, Jonathan Corbet <corbet@lwn•net>,
linux-doc@vger•kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Jiri Pirko <jiri@resnulli•us>,
Paul Greenwalt <paul.greenwalt@intel•com>,
Ahmed Zaki <ahmed.zaki@intel•com>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Kory Maincent <kory.maincent@bootlin•com>,
Andrew Lunn <andrew@lunn•ch>,
justinstitt@google•com, donald.hunter@gmail•com,
netdev@vger•kernel.org, virtualization@lists•linux.dev
Subject: Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management
Date: Mon, 13 May 2024 08:24:12 -0700 [thread overview]
Message-ID: <20240513082412.2a27f965@kernel.org> (raw)
In-Reply-To: <1715611933.2264705-1-hengqi@linux.alibaba.com>
On Mon, 13 May 2024 22:52:13 +0800 Heng Qi wrote:
> > > So I think we should declare "CONFIG_PROVE_LOCKING depends on CONFIG_NET".
> > > How do you think?
> >
> > Doesn't sound right, `can we instead make building lib/dim/net_dim.c
>
> Why? IIUC, the reason is that if CONFIG_NET is not set to Y, the net/core
> directory will not be compiled, so the lockdep_rtnl_is_held symbol is not
> present.
Maybe I don't understand what you;re proposing.
Show an actual diff please.
> > dependent on CONFIG_NET? Untested but I'm thinking something like:
> >
> > diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> > index c4cc4026c451..c02c306e2975 100644
> > --- a/lib/dim/Makefile
> > +++ b/lib/dim/Makefile
> > @@ -4,4 +4,8 @@
> >
> > obj-$(CONFIG_DIMLIB) += dimlib.o
> >
> > -dimlib-objs := dim.o net_dim.o rdma_dim.o
> > +dimlib-objs := dim.o rdma_dim.o
> > +
> > +ifeq ($(CONFIG_NET),y)
> > +dimlib-objs += net_dim.o
> > +endif
>
> 1. This is unlikely to work if the kernel is configured as[1]:
>
> [1] kernel configuration
> CONFIG_NET=n, CONFIG_ETHTOOL_NETLINK=n, CONFIG_PROVE_LOCKING=y,
> (CONFIG_FSL_MC_DPIO=y && CONFIG_FSL_MC_BUS=y) select CONFIG_DIMLIB=y.
>
>
> Then, because CONFIG_NET is not enabled, so there is no net_dim.o,
> the following warning appears:
>
> ld.lld: error: undefined symbol: net_dim_get_rx_moderation
> referenced by dpio-service.c
> drivers/soc/fsl/dpio/dpio-service.o:(dpaa2_io_dim_work) in archive vmlinux.a
>
> ld.lld: error: undefined symbol: net_dim
> referenced by dpio-service.c
> drivers/soc/fsl/dpio/dpio-service.o:(dpaa2_io_update_net_dim) in archive vmlinux.a
Simple, dpio-service should depend on NET if it wants NET_DIM
next prev parent reply other threads:[~2024-05-13 15:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 4:47 [PATCH net-next v13 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-05-09 4:47 ` [PATCH net-next v13 1/4] linux/dim: move useful macros to .h file Heng Qi
2024-05-09 4:47 ` [PATCH net-next v13 2/4] ethtool: provide customized dim profile management Heng Qi
2024-05-09 23:09 ` kernel test robot
2024-05-12 16:36 ` Heng Qi
2024-05-13 14:22 ` Jakub Kicinski
2024-05-13 14:52 ` Heng Qi
2024-05-13 15:24 ` Jakub Kicinski [this message]
2024-05-13 15:39 ` Heng Qi
2024-05-13 18:42 ` Jakub Kicinski
2024-05-14 2:08 ` Heng Qi
2024-05-14 13:46 ` Jakub Kicinski
2024-05-14 16:36 ` Andrew Lunn
2024-05-09 4:47 ` [PATCH net-next v13 3/4] dim: add new interfaces for initialization and getting results Heng Qi
2024-05-09 4:47 ` [PATCH net-next v13 4/4] virtio-net: support dim profile fine-tuning Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513082412.2a27f965@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bcreeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hengqi@linux$(echo .)alibaba.com \
--cc=jasowang@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=justinstitt@google$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=llvm@lists$(echo .)linux.dev \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=paul.greenwalt@intel$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=talgi@nvidia$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox