From: Herve Codina <herve.codina@bootlin•com>
To: <Steen.Hegelund@microchip•com>
Cc: <tglx@linutronix•de>, <robh@kernel•org>, <krzk+dt@kernel•org>,
<conor+dt@kernel•org>, <davem@davemloft•net>,
<edumazet@google•com>, <kuba@kernel•org>, <pabeni@redhat•com>,
<lee@kernel•org>, <arnd@arndb•de>, <Horatiu.Vultur@microchip•com>,
<UNGLinuxDriver@microchip•com>, <andrew@lunn•ch>,
<hkallweit1@gmail•com>, <linux@armlinux•org.uk>,
<saravanak@google•com>, <bhelgaas@google•com>,
<p.zabel@pengutronix•de>, <Lars.Povlsen@microchip•com>,
<Daniel.Machon@microchip•com>, <alexandre.belloni@bootlin•com>,
<linux-kernel@vger•kernel.org>, <devicetree@vger•kernel.org>,
<netdev@vger•kernel.org>, <linux-pci@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>,
<Allan.Nielsen@microchip•com>, <luca.ceresoli@bootlin•com>,
<thomas.petazzoni@bootlin•com>
Subject: Re: [PATCH 12/17] irqchip: Add support for LAN966x OIC
Date: Mon, 13 May 2024 14:50:49 +0200 [thread overview]
Message-ID: <20240513145049.25695b4a@bootlin.com> (raw)
In-Reply-To: <D143YFK7334S.3MM7YORC0H24X@microchip.com>
Hi Steen,
On Wed, 8 May 2024 08:08:30 +0000
<Steen.Hegelund@microchip•com> wrote:
...
> > +/* Mapping of source to destination interrupts (_n = 0..8) */
>
> Are the indices really needed on LAN966X_OIC_DST_INTR_MAP* and _IDENT*
> You do not appear to be using them?
>
>
> > +#define LAN966X_OIC_DST_INTR_MAP(_n) 0x78
Indeed, I missed them.
These registers are defined from 0 to 8 in the document:
https://microchip-ung.github.io/lan9662_reginfo/reginfo_LAN9662.html?select=cpu,intr
The code use only the indice 0.
In the next iteration, I will keep indices and update the definition of
registers like that:
#define LAN966X_OIC_DST_INTR_MAP(_n) (0x78 + (_n) * 4)
Best regards
Hervé
next prev parent reply other threads:[~2024-05-13 12:50 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 8:37 [PATCH 00/17] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-04-30 8:37 ` [PATCH 01/17] mfd: syscon: Add reference counting and device managed support Herve Codina
2024-04-30 20:34 ` Simon Horman
2024-05-02 13:29 ` Herve Codina
2024-04-30 21:55 ` kernel test robot
2024-04-30 22:07 ` kernel test robot
2024-04-30 8:37 ` [PATCH 02/17] reset: mchp: sparx5: Remove dependencies and allow building as a module Herve Codina
2024-04-30 8:37 ` [PATCH 03/17] reset: mchp: sparx5: Release syscon when not use anymore Herve Codina
2024-04-30 8:37 ` [PATCH 04/17] reset: core: add get_device()/put_device on rcdev Herve Codina
2024-06-21 10:16 ` Philipp Zabel
2024-04-30 8:37 ` [PATCH 05/17] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
2024-04-30 8:37 ` [PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property Herve Codina
2024-04-30 13:55 ` Andrew Lunn
2024-04-30 15:40 ` Herve Codina
2024-04-30 16:31 ` Andrew Lunn
2024-05-02 9:50 ` Herve Codina
2024-05-02 10:31 ` Conor Dooley
2024-05-02 12:26 ` Andrew Lunn
2024-05-02 13:22 ` Alexandre Belloni
2024-05-03 14:21 ` Herve Codina
2024-04-30 8:37 ` [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset Herve Codina
2024-04-30 9:21 ` Sai Krishna Gajula
2024-05-02 13:26 ` Herve Codina
2024-04-30 13:46 ` Andrew Lunn
2024-04-30 15:40 ` Herve Codina
2024-04-30 8:37 ` [PATCH 08/17] net: lan966x: remove debugfs directory in probe() error path Herve Codina
2024-04-30 13:57 ` Andrew Lunn
2024-04-30 14:01 ` Andrew Lunn
2024-04-30 8:37 ` [PATCH 09/17] dt-bindings: interrupt-controller: Add support for Microchip LAN966x OIC Herve Codina
2024-05-07 15:28 ` Rob Herring
2024-05-13 12:37 ` Herve Codina
2024-05-13 14:53 ` Rob Herring
2024-05-13 17:04 ` Herve Codina
2024-05-22 14:24 ` Rob Herring (Arm)
2024-04-30 8:37 ` [PATCH 10/17] irqdomain: Add missing parameter descriptions in docs Herve Codina
2024-05-02 0:03 ` Thomas Gleixner
2024-04-30 8:37 ` [PATCH 11/17] irqdomain: Introduce irq_domain_alloc() and irq_domain_publish() Herve Codina
2024-04-30 8:37 ` [PATCH 12/17] irqchip: Add support for LAN966x OIC Herve Codina
2024-04-30 20:24 ` Simon Horman
2024-05-02 13:24 ` Herve Codina
2024-05-01 1:17 ` kernel test robot
2024-05-08 8:08 ` Steen.Hegelund
2024-05-13 12:50 ` Herve Codina [this message]
2024-04-30 8:37 ` [PATCH 13/17] MAINTAINERS: Add the Microchip LAN966x OIC driver entry Herve Codina
2024-04-30 8:37 ` [PATCH 14/17] of: dynamic: Introduce of_changeset_add_prop_bool() Herve Codina
2024-05-08 18:03 ` Rob Herring
2024-04-30 8:37 ` [PATCH 15/17] pci: of_property: Add the interrupt-controller property in PCI device nodes Herve Codina
2024-05-01 17:38 ` Bjorn Helgaas
2024-05-03 14:40 ` Herve Codina
2024-04-30 8:37 ` [PATCH 16/17] mfd: Add support for LAN966x PCI device Herve Codina
2024-05-08 8:20 ` Steen.Hegelund
2024-05-14 12:55 ` Herve Codina
2024-04-30 8:37 ` [PATCH 17/17] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
2024-04-30 13:40 ` [PATCH 00/17] Add support for the LAN966x PCI device using a DT overlay Andrew Lunn
2024-04-30 16:33 ` Herve Codina
2024-04-30 18:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513145049.25695b4a@bootlin.com \
--to=herve.codina@bootlin$(echo .)com \
--cc=Allan.Nielsen@microchip$(echo .)com \
--cc=Daniel.Machon@microchip$(echo .)com \
--cc=Horatiu.Vultur@microchip$(echo .)com \
--cc=Lars.Povlsen@microchip$(echo .)com \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=luca.ceresoli@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=saravanak@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox