Subject: Re: [PATCH net-next 2/2] tcp: add sysctl_tcp_rto_min_us

From: Jakub Kicinski <[email-masked]>
Date: Wed, 29 May 2024 16:47:04 -0700

On Tue, 28 May 2024 17:13:20 +0000 Kevin Yang wrote:
> +	icsk->icsk_rto_min = usecs_to_jiffies(READ_ONCE(sock_net(sk)->
> +					      ipv4.sysctl_tcp_rto_min_us));

This is somewhat awkwardly broken into two lines.
Could you use a temp variable to save 

	rto_min_us = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_rto_min_us);

?

Or just go over 80 chars, but preferably not. Chaining 3 calls in one
line is a bit Java-esque :S

With that feel free to add:

Reviewed-by: Jakub Kicinski <[email-masked]>

We also carry (a form of) this patch in Meta kernels.. :(