Subject: Re: [PATCH net-next v1] netfilter: nfnetlink: convert kfree_skb to consume_skb

From: Simon Horman <[email-masked]>
Date: Fri, 31 May 2024 17:14:10 +0100

On Tue, May 28, 2024 at 11:37:54AM +0100, Donald Hunter wrote:
> Use consume_skb in the batch code path to avoid generating spurious
> NOT_SPECIFIED skb drop reasons.
> 
> Signed-off-by: Donald Hunter <[email-masked]>

Hi Donald,

I do wonder if this is the correct approach. I'm happy to stand corrected,
but my understanding is that consume_skb() is for situations where the skb
is no longer needed for reasons other than errors. But some of these
call-sites do appear to be error paths of sorts.

...