Subject: Re: [net-next PATCH v3] octeontx2-af: Add debugfs support to dump NIX TM topology

From: Simon Horman <[email-masked]>
Date: Tue, 4 Jun 2024 19:18:59 +0100

On Mon, Jun 03, 2024 at 04:52:48PM +0530, Anshumali Gaur wrote:
> This patch adds support to dump NIX transmit queue topology.
> There are multiple levels of scheduling/shaping supported by
> NIX and a packet traverses through multiple levels before sending
> the packet out. At each level, there are set of scheduling/shaping
> rules applied to a packet flow.
> 
> Each packet traverses through multiple levels
> SQ->SMQ->TL4->TL3->TL2->TL1 and these levels are mapped in a parent-child
> relationship.
> 
> This patch dumps the debug information related to all TM Levels in
> the following way.
> 
> Example:
> $ echo <nixlf> > /sys/kernel/debug/octeontx2/nix/tm_tree
> $ cat /sys/kernel/debug/octeontx2/nix/tm_tree
> 
> A more desriptive set of registers at each level can be dumped
> in the following way.
> 
> Example:
> $ echo <nixlf> > /sys/kernel/debug/octeontx2/nix/tm_topo
> $ cat /sys/kernel/debug/octeontx2/nix/tm_topo
> 
> Signed-off-by: Anshumali Gaur <[email-masked]>
> ---
> v3:
>     - Addressed review comments given by Wojciech Drewek
> 	1. Removed unnecessary goto statement
> 	2. Moved valid SQ check before AF mbox
> v2:
>     - Addressed review comments given by Simon Horman
> 	1. Resolved indentation issues

Hi Anshumali,

Thanks for the updates.

Reviewed-by: Simon Horman <[email-masked]>