Subject: Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect

From: Maxime Chevallier <[email-masked]>
Date: Thu, 6 Jun 2024 08:57:34 +0200

Hello Jakub,

On Wed, 5 Jun 2024 20:10:25 -0700
Jakub Kicinski <[email-masked]> wrote:

> On Wed,  5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote:
> > +/**
> > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY
> > + * @upstream: pointer to the upstream phy device
> > + * @phy: pointer to the SFP module's phy device
> > + *
> > + * This helper allows keeping track of PHY devices on the link. It adds the
> > + * SFP module's phy to the phy namespace of the upstream phy
> > + */
> > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy)  
> 
> We run scripts/kernel-doc with -Wall now, it wants return values
> to be documented, too. 

OK, I'll address that and make sure to run this script on all the
patches in the series.

Thanks,

Maxime