From: Florian Westphal <fw@strlen•de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
Cc: Florian Westphal <fw@strlen•de>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Christoph Paasch <cpaasch@apple•com>,
Netfilter <netfilter-devel@vger•kernel.org>,
Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, daniel@iogearbox•net, willemb@google•com
Subject: Re: [PATCH nf] netfilter: nf_reject: init skb->dev for reset packet
Date: Thu, 6 Jun 2024 16:52:01 +0200 [thread overview]
Message-ID: <20240606145201.GD9890@breakpoint.cc> (raw)
In-Reply-To: <6661cb237158e_37d9572949b@willemb.c.googlers.com.notmuch>
Willem de Bruijn <willemdebruijn.kernel@gmail•com> wrote:
> > This currently works because skb_get_hash computes it at most once.
>
> Probably not relevant to these skbs, that don't have an skb->sk.
>
> But in case skbs coming from the TCP stack are also in scope: can
> sk_rethink_txhash cause problems?
No, thats fine for the nf_trace infra.
prev parent reply other threads:[~2024-06-06 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240604120311.27300-1-fw@strlen.de>
[not found] ` <FF8A506F-6F0F-440E-9F52-B27D05731B77@apple.com>
[not found] ` <20240605181450.GA7176@breakpoint.cc>
2024-06-05 18:38 ` [PATCH nf] netfilter: nf_reject: init skb->dev for reset packet Pablo Neira Ayuso
2024-06-05 19:08 ` Florian Westphal
2024-06-05 19:45 ` Pablo Neira Ayuso
2024-06-05 21:38 ` Willem de Bruijn
2024-06-05 22:16 ` Pablo Neira Ayuso
2024-06-06 1:54 ` Willem de Bruijn
2024-06-06 6:20 ` Pablo Neira Ayuso
2024-06-06 8:39 ` Florian Westphal
2024-06-06 9:26 ` Florian Westphal
2024-06-06 13:04 ` Florian Westphal
2024-06-06 14:09 ` Willem de Bruijn
2024-06-06 14:15 ` Florian Westphal
2024-06-06 14:28 ` Willem de Bruijn
2024-06-06 14:38 ` Florian Westphal
2024-06-06 14:43 ` Willem de Bruijn
2024-06-06 14:52 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606145201.GD9890@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=cpaasch@apple$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=willemb@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox