From: Simon Horman <horms@kernel•org>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com,
andrew.gospodarek@broadcom•com,
Somnath Kotur <somnath.kotur@broadcom•com>,
Pavan Chebbi <pavan.chebbi@broadcom•com>
Subject: Re: [PATCH net] bnxt_en: Cap the size of HWRM_PORT_PHY_QCFG forwarded response
Date: Fri, 7 Jun 2024 14:50:46 +0100 [thread overview]
Message-ID: <20240607135046.GD27689@kernel.org> (raw)
In-Reply-To: <20240606175107.53130-1-michael.chan@broadcom.com>
On Thu, Jun 06, 2024 at 10:51:07AM -0700, Michael Chan wrote:
> Firmware interface 1.10.2.118 has increased the size of
> HWRM_PORT_PHY_QCFG response beyond the maximum size that can be
> forwarded. When the VF's link state is not the default auto state,
> the PF will need to forward the response back to the VF to indicate
> the forced state. This regression may cause the VF to fail to
> initialize.
>
> Fix it by capping the HWRM_PORT_PHY_QCFG response to the maximum
> 96 bytes. Also modify bnxt_hwrm_fwd_resp() to print a warning if the
> message size exceeds 96 bytes to make this failure more obvious.
>
> Bug: DCSG01725771
> Change-Id: I4cd5e06a7625f9d06e779e4acd9603d355883e7c
Hi Michael,
Does the above relate to publicly available information?
If so, a link is probably in order. If not, let's drop it.
> Fixes: 84a911db8305 ("bnxt_en: Update firmware interface to 1.10.2.118")
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom•com>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom•com>
> Signed-off-by: Michael Chan <michael.chan@broadcom•com>
...
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
...
> @@ -1096,6 +1099,8 @@ static int bnxt_vf_set_link(struct bnxt *bp, struct bnxt_vf_info *vf)
> mutex_unlock(&bp->link_lock);
> phy_qcfg_resp.resp_len = cpu_to_le16(sizeof(phy_qcfg_resp));
> phy_qcfg_resp.seq_id = phy_qcfg_req->seq_id;
> + phy_qcfg_resp.option_flags &=
> + ~PORT_PHY_QCAPS_RESP_FLAGS2_SPEEDS2_SUPPORTED;
I may be missing something obvious, but it is not clear to me
how this change relates to the rest of the patch.
> phy_qcfg_resp.valid = 1;
>
> if (vf->flags & BNXT_VF_LINK_UP) {
> --
> 2.30.1
>
next prev parent reply other threads:[~2024-06-07 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 17:51 [PATCH net] bnxt_en: Cap the size of HWRM_PORT_PHY_QCFG forwarded response Michael Chan
2024-06-07 13:50 ` Simon Horman [this message]
2024-06-08 15:19 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607135046.GD27689@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox