From: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
To: Rob Herring <robh@kernel•org>
Cc: Marco Felsch <m.felsch@pengutronix•de>,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, krzysztof.kozlowski+dt@linaro•org,
conor+dt@kernel•org, peppe.cavallaro@st•com,
alexandre.torgue@foss•st.com, joabreu@synopsys•com,
mcoquelin.stm32@gmail•com, devicetree@vger•kernel.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@pengutronix•de, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support
Date: Sat, 8 Jun 2024 18:21:36 +0300 [thread overview]
Message-ID: <20240608152136.GA14446@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230721142433.GA1012219-robh@kernel.org>
Hi Rob,
On Fri, Jul 21, 2023 at 08:24:33AM -0600, Rob Herring wrote:
> On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote:
> > Document the common phy-supply property to be able to specify a phy
> > regulator.
>
> What common property? I don't see any such property in
> ethernet-controller.yaml.
>
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix•de>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>
> > ---
> > Changelog:
> > v4:
> > - no changes
> > v3:
> > - no changes
> > v2
> > - add ack-by
> >
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index ddf9522a5dc23..847ecb82b37ee 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -160,6 +160,9 @@ properties:
> > can be passive (no SW requirement), and requires that the MAC operate
> > in a different mode than the PHY in order to function.
> >
> > + phy-supply:
> > + description: PHY regulator
>
> Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way,
> this property belongs in the PHY's node because it is the PHY that has
> supply connection. I'm guessing you put this here for the latter case
> because ethernet PHYs on MDIO are "discoverable" except for the small
> problem that powering them on is not discoverable.
Any idea on how to solve that problem generically ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-06-08 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 11:03 [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support Marco Felsch
2023-07-21 11:03 ` [PATCH net-next v4 2/3] net: stmmac: introduce small helper to check STMMAC_FLAG_USE_PHY_WOL Marco Felsch
2023-07-21 11:03 ` [PATCH net-next v4 3/3] net: stmmac: add support for phy-supply Marco Felsch
2023-07-21 14:24 ` [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support Rob Herring
2023-07-24 9:39 ` Marco Felsch
2023-08-09 9:01 ` Marco Felsch
2024-06-08 15:21 ` Laurent Pinchart [this message]
2023-08-29 11:02 ` [PATCH net-next v4 1/3] dt-bindings: net: snps, dwmac: " Marco Felsch
2023-09-18 6:42 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240608152136.GA14446@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox