Subject: Re: [PATCH net-next v2] net: dqs: introduce IFF_NO_BQL private flag for non-BQL drivers

From: Jakub Kicinski <[email-masked]>
Date: Wed, 12 Jun 2024 14:40:23 -0700

On Tue, 11 Jun 2024 11:32:03 +0800 Jason Xing wrote:
> +++ b/include/linux/netdevice.h
> @@ -1649,6 +1649,9 @@ struct net_device_ops {
>   * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to
>   *	ndo_hwtstamp_set() for all timestamp requests regardless of source,
>   *	even if those aren't HWTSTAMP_SOURCE_NETDEV.
> + * @IFF_NO_BQL: driver doesn't use BQL for flow control for now. It's used
> + *	to check if we should create byte_queue_limits directory in dqs
> + *	(see netdev_uses_bql())

Sorry for nit but since it's netdevice.h.. can we rephrase the comment
a bit? How about just:

+ * @IFF_NO_BQL: driver doesn't support BQL, don't create "byte_queue_limits"
+ *	directories in sysfs.