Subject: Re: [PATCH] ethernet: sis900: use sizeof(*pointer) instead of sizeof(type)

From: Jakub Kicinski <[email-masked]>
Date: Wed, 12 Jun 2024 17:55:16 -0700

On Sat,  8 Jun 2024 12:20:33 +0200 Erick Archer wrote:
> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter).
> 
> At the same time remove some unnecessary initializations and
> refactor a bit to make the code clearer.
> 
> This patch has no effect on runtime behavior.

This is an ancient driver, unfortunately we prefer not to apply minor
code cleanups of this nature unless they are a part of other development
work. We'd be constantly tweaking the 200+ drivers we have, most of
which get zero use.
-- 
pw-bot: reject