Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down

From: Jakub Kicinski <[email-masked]>
Date: Thu, 13 Jun 2024 08:12:33 -0700

On Tue, 11 Jun 2024 10:04:05 +0200 Csókás, Bence wrote:
> +	if (fep->bufdesc_ex) {
> +		val = readl(fep->hwp + FEC_ECNTRL);
> +		val |= FEC_ECR_EN1588;
> +		writel(val, fep->hwp + FEC_ECNTRL);

FEC_ECNTRL gets written multiple times in this function,
including with 0, and then you RMW it to add this flag.

Is this intentional? It really seems like you should be
adding this flag more consistently or making sure its
not cleared, rather than appending "add it back" at the 
end of the function...
-- 
pw-bot: cr