Subject: Re: [net-next v1] net: wwan: t7xx: Add debug port

From: Jakub Kicinski <[email-masked]>
Date: Fri, 14 Jun 2024 08:11:36 -0700

On Fri, 14 Jun 2024 17:49:51 +0800 Vanillan Wang wrote:
> From: Jinjian Song <[email-masked]>
> 
> Add support for userspace to switch on the debug port(ADB,MIPC).
>  - ADB port: /dev/ccci_sap_adb
>  - MIPC port: /dev/ttyMIPC0
> 
> Switch on debug port:
>  - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode
> 
> Switch off debug port:
>  - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode

You need to provide more detail on what it does and how it's used.

> +	txq_mtu = t7xx_get_port_mtu(port);
> +	if (txq_mtu < 0)
> +		return -EINVAL;

drivers/net/wwan/t7xx/t7xx_port_debug.c:153:5-12: WARNING: Unsigned expression compared with zero: txq_mtu < 0
-- 
pw-bot: cr