Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down

From: Jakub Kicinski <[email-masked]>
Date: Fri, 14 Jun 2024 18:27:31 -0700

On Fri, 14 Jun 2024 09:59:16 +0200 Csókás Bence wrote:
> It only writes 0 if WOL is disabled AND the device has the MULTI_QUEUES 
> quirk. Otherwise, we either write FEC_ECR_RESET, which resets the device 
> (and the HW changes ECNTRL to its reset value), OR we RMW set the WOL 
> sleep bits. And then, if some more quirks are set, we set ETHEREN.
> 
> So I think RMW is the safest route here, instead of trying to keep track 
> of all these different branches, re-read ECNTRL after reset etc.

Okay, just resend without the empty line between tags then.