Subject: Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to fill stats strings

From: Jakub Kicinski <[email-masked]>
Date: Fri, 14 Jun 2024 18:37:52 -0700

On Thu, 13 Jun 2024 14:43:33 -0400 Kamal Heib wrote:
> Use the ethtool_puts/ethtool_sprintf helper to print the stats strings
> into the ethtool strings interface.
> 
> Signed-off-by: Kamal Heib <[email-masked]>

minor build issue with this one:

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:453:6: warning: unused variable 'index' [-Wunused-variable]
  453 |         int index = 0;
      |             ^~~~~

otherwise LGTM!
-- 
pw-bot: cr