Subject: Re: [PATCH net-next v2 3/5] gve: Add flow steering device option

From: Jakub Kicinski <[email-masked]>
Date: Fri, 14 Jun 2024 19:22:09 -0700

On Thu, 13 Jun 2024 01:47:42 +0000 Ziwei Xiao wrote:
> +	if (dev_op_flow_steering &&
> +	    (supported_features_mask & GVE_SUP_FLOW_STEERING_MASK)) {
> +		if (dev_op_flow_steering->max_flow_rules) {
> +			priv->max_flow_rules =
> +				be32_to_cpu(dev_op_flow_steering->max_flow_rules);
> +			dev_info(&priv->pdev->dev,
> +				 "FLOW STEERING device option enabled with max rule limit of %u.\n",
> +				 priv->max_flow_rules);

There's a print to the kernel logs every time driver loads to tell 
the user flow steering is available...

> -	/* DQO supports LRO. */
>  	if (!gve_is_gqi(priv))
> -		priv->dev->hw_features |= NETIF_F_LRO;
> +		priv->dev->hw_features |= NETIF_F_LRO | NETIF_F_NTUPLE;

Yet the uAPI feature which is supposed to let the user know its
supported appears to be set unconditionally.