From: Simon Horman <horms@kernel•org>
To: Petr Oros <poros@redhat•com>
Cc: netdev@vger•kernel.org, ivecera@redhat•com,
przemyslaw.kitszel@intel•com,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Marcin Szycik <marcin.szycik@linux•intel.com>,
Konrad Knitter <konrad.knitter@intel•com>,
Marcin Domagala <marcinx.domagala@intel•com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists•osuosl.org>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net v2] ice: use proper macro for testing bit
Date: Sat, 15 Jun 2024 16:16:41 +0100 [thread overview]
Message-ID: <20240615151641.GG8447@kernel.org> (raw)
In-Reply-To: <20240614094338.467052-1-poros@redhat.com>
On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote:
> Do not use _test_bit() macro for testing bit. The proper macro for this
> is one without underline.
Hi Petr,
it might be nice to include a brief explanation as to
why test_bit() is correct.
>
> Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
> Signed-off-by: Petr Oros <poros@redhat•com>
> Acked-by: Ivan Vecera <ivecera@redhat•com>
...
next prev parent reply other threads:[~2024-06-15 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 9:43 [PATCH net v2] ice: use proper macro for testing bit Petr Oros
2024-06-15 15:16 ` Simon Horman [this message]
2024-06-17 12:58 ` Alexander Lobakin
2024-06-17 19:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240615151641.GG8447@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ivecera@redhat$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=konrad.knitter@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=marcin.szycik@linux$(echo .)intel.com \
--cc=marcinx.domagala@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=poros@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox